From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Mon, 07 Feb 2022 00:14:04 +0100 Message-ID: <87r18f4mgz.fsf@gnus.org> References: <83v8y8ij39.fsf@gnu.org> <6a5bb5a08b3d764611f9@heytings.org> <6a5bb5a08b6337d733c5@heytings.org> <87ilttg81b.fsf@gnus.org> <87v8xtatlr.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15679"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: mattiase@acm.org, Gregory Heytings , Eli Zaretskii , Stefan Monnier , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 07 00:16:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGqle-0003nw-Hh for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Feb 2022 00:16:26 +0100 Original-Received: from localhost ([::1]:42314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGqld-0007Dn-6q for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Feb 2022 18:16:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGqjY-0005rj-Gg for emacs-devel@gnu.org; Sun, 06 Feb 2022 18:14:16 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=50874 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGqjW-0002aj-Dk; Sun, 06 Feb 2022 18:14:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jMhjRhJz23muscrmSoVTKYsUY3bvbwp6vBlkvH8tB4o=; b=faRO2Go5tdNo/rHZcfNvqor3ho JlPkpQHrmiuJp97pXt7aFGpobGkIsUWuWjhDvMnswg21upXv0Yt/Yumw4GBUg+bLF96Mq+0EB4sQs O6OF6e4gouMxfshK4jqyrneZnvC4c/yhcuV6Z5LIlG71VhzHDE4FvDS8Vpin4kFWBYyE=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGqjP-0000sQ-7R; Mon, 07 Feb 2022 00:14:10 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUQCgxdMDliTJNL PYLCWjejTiPejHr///+9aF0aAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YCBhcDLFP+1FYAAAGfSURB VDjLbZJNbsMgEIVxo2Rt2rBvSA4QixO4HVgHCfZNRbj/ETrDf9y8yLHMN+8Ng80YY3wQS5rzTQ46 s4nxSS3XAi5SftHf5YQmMb9/X9k0F0cC8rzwedkpOYCcJBWSs5TXbQ+pPpbdK6AUX5RSrx0IVAK/ Gwtp3jiUEj7p9gQUz6teuw4WTrWukAZOJcE/g5OvwRXAjb19slqtGTvqbEBwuLPacEW3a2Z0jGDf wOGnBrsVX9PUmmOULmQVOG+xJ4f2BXFbgS+gyvIOUB1wSBj3P9Mb1N0QdboR2N8Gh4tkoaNExwhM DLnA/gMpCw95bI7nHgugAXtzzh2CR3UgaHvCJBPq5FN6CZbGJlC7VweO5LRIQI8AZ3UxGAJQwZ6i OLe0SALoZ0VApEW6jKXmc57D8iPF06bArD4dSXJYDzkqAMS7qJPTV4EgRLwMxIfwUIAALMQ1EyEA 7RfyB5cMAePjFnhIQkTSOCs8A/yhhAate3MACgQNgZ7aWaFH47OmAvJ34HJ8hKIS5XMbU9pjRQeO YprBd5BdWOBci3qpPzUxBQ9waXW8AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTAyLTA2VDIzOjAz OjQ0KzAwOjAwwn/57gAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wMi0wNlQyMzowMzo0NCswMDow MLMiQVIAAAAASUVORK5CYII= X-Now-Playing: Alice Coltrane's _Eternity_: "Los Caballos" In-Reply-To: (Alan Mackenzie's message of "Sun, 6 Feb 2022 11:38:21 +0000") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285994 Archived-At: Alan Mackenzie writes: > By doing something like calling read rather than read-positioning-symbols > from the byte compiler, and putting conditional compilation into > lisp_h_EQ, etc., in src/lisp.h? This would leave the compiler not fully > functional, of course. It might work. Or just have conditional compilation of lisp_h_EQ and have read-positioning-symbols be an alias for read (when this is disabled). Or something like that. So the code impact of the configuration option could be very localised. > I would more favour the slightly more laborious strategy: benchmark on > the master branch in two repositories, one just before the big merge, the > other just after. People don't like to skip back in git history much, because other code has also moved on since that time, and you end up with various obscure issues very fast. Configuration options are just more handy. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no