* Re: master f52dcfd03a: New command `gnus-summary-browse-all-urls' bound to "v"
[not found] ` <20220314152841.8DC85C06305@vcs2.savannah.gnu.org>
@ 2022-03-15 11:39 ` Lars Ingebrigtsen
2022-03-15 15:26 ` Sam Steingold
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2022-03-15 11:39 UTC (permalink / raw)
To: emacs-devel; +Cc: Sam Steingold
Sam Steingold <sds@gnu.org> writes:
> branch: master
> commit f52dcfd03ad542704d9a43faab0c33be09ab442e
> Author: Sam Steingold <sds@gnu.org>
> Commit: Sam Steingold <sds@gnu.org>
>
> New command `gnus-summary-browse-all-urls' bound to "v"
>
> * lisp/gnus-sum.el (gnus-collect-urls-from-article): New function,
> extracted from `gnus-summary-browse-url'.
> (gnus-summary-browse-url): Use it; also use `browse-url-button-open-url'
> to handle the prefix argument.
> (gnus-summary-browse-all-urls): New command.
> (gnus-summary-mode-map): Bind `gnus-summary-browse-all-urls' to "v".
I've reverted this patch -- I did not agree that this command should be
added, so you should not have pushed it, Sam.
To reiterate -- I don't think this command sounds generally useful, and
furthermore, if it is, it should not be bound to such a convenient key
like `v', and moreover, the funky calling conventions of
`browse-url-button-open-url' should be avoided.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master f52dcfd03a: New command `gnus-summary-browse-all-urls' bound to "v"
2022-03-15 11:39 ` master f52dcfd03a: New command `gnus-summary-browse-all-urls' bound to "v" Lars Ingebrigtsen
@ 2022-03-15 15:26 ` Sam Steingold
2022-03-15 15:30 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Sam Steingold @ 2022-03-15 15:26 UTC (permalink / raw)
To: emacs-devel
> * Lars Ingebrigtsen <ynefv@tahf.bet> [2022-03-15 12:39:00 +0100]:
>
> Sam Steingold <sds@gnu.org> writes:
>
>> branch: master
>> commit f52dcfd03ad542704d9a43faab0c33be09ab442e
>> Author: Sam Steingold <sds@gnu.org>
>> Commit: Sam Steingold <sds@gnu.org>
>>
>> New command `gnus-summary-browse-all-urls' bound to "v"
>>
>> * lisp/gnus-sum.el (gnus-collect-urls-from-article): New function,
>> extracted from `gnus-summary-browse-url'.
>> (gnus-summary-browse-url): Use it; also use `browse-url-button-open-url'
>> to handle the prefix argument.
>> (gnus-summary-browse-all-urls): New command.
>> (gnus-summary-mode-map): Bind `gnus-summary-browse-all-urls' to "v".
>
> I've reverted this patch -- I did not agree that this command should be
> added, so you should not have pushed it, Sam.
Sorry about the misunderstanding.
> To reiterate -- I don't think this command sounds generally useful, and
> furthermore, if it is, it should not be bound to such a convenient key
May I at least keep `gnus-collect-urls-from-article'?
> like `v', and moreover, the funky calling conventions of
> `browse-url-button-open-url' should be avoided.
Well, I suppose you will add a deprecation decoration to the function.
--
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.2113
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
https://www.memritv.org https://memri.org https://jij.org
Your mouse has moved - WinNT has to be restarted for this to take effect.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master f52dcfd03a: New command `gnus-summary-browse-all-urls' bound to "v"
2022-03-15 15:26 ` Sam Steingold
@ 2022-03-15 15:30 ` Lars Ingebrigtsen
0 siblings, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2022-03-15 15:30 UTC (permalink / raw)
To: Sam Steingold; +Cc: emacs-devel
(Forgot the CCs; resending.)
Sam Steingold <sds@gnu.org> writes:
>> To reiterate -- I don't think this command sounds generally useful, and
>> furthermore, if it is, it should not be bound to such a convenient key
>
> May I at least keep `gnus-collect-urls-from-article'?
Sure, that seems generally useful.
>> like `v', and moreover, the funky calling conventions of
>> `browse-url-button-open-url' should be avoided.
>
> Well, I suppose you will add a deprecation decoration to the function.
It's not a deprecated function -- it's a function meant to be used from
the button machinery, which is why it's got an odd signature, if I
remember correctly.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-15 15:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <164727172121.17436.14797611985358127835@vcs2.savannah.gnu.org>
[not found] ` <20220314152841.8DC85C06305@vcs2.savannah.gnu.org>
2022-03-15 11:39 ` master f52dcfd03a: New command `gnus-summary-browse-all-urls' bound to "v" Lars Ingebrigtsen
2022-03-15 15:26 ` Sam Steingold
2022-03-15 15:30 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).