From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Cohen Newsgroups: gmane.emacs.devel Subject: [PATCH] Fix bug in nnselect fetching new articles in a thread Date: Wed, 16 Mar 2022 11:52:10 +0800 Message-ID: <87r172ftat.fsf@ust.hk> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16733"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org Cancel-Lock: sha1:0Vdg/wQZLPpnuxhM1vzTPHQeTbw= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 16 04:53:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUKiu-0004DZ-AR for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Mar 2022 04:53:20 +0100 Original-Received: from localhost ([::1]:41914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUKit-0004rZ-0p for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Mar 2022 23:53:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUKhv-00042P-JY for emacs-devel@gnu.org; Tue, 15 Mar 2022 23:52:20 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:39976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUKht-0005XM-Rn for emacs-devel@gnu.org; Tue, 15 Mar 2022 23:52:19 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nUKhr-0002uV-LA for emacs-devel@gnu.org; Wed, 16 Mar 2022 04:52:15 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287208 Archived-At: Thanks to Eli and the GNU copyright staff, my copyright issues have now been solved. Eli has instructed me to send all patches to the list prior to pushing to the repository, so I have a fair number of small changes in the pipeline. This is the first: * lisp/gnus/nnselect.el (nnselect-request-thread): Ignore the Retrieval Status Value in comparing whether articles are the same. --- lisp/gnus/nnselect.el | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lisp/gnus/nnselect.el b/lisp/gnus/nnselect.el index c880d79840..586dec65af 100644 --- a/lisp/gnus/nnselect.el +++ b/lisp/gnus/nnselect.el @@ -652,8 +652,15 @@ nnselect-request-thread (lambda (article) (if (setq seq - (cl-position article - gnus-newsgroup-selection :test 'equal)) + (cl-position + article + gnus-newsgroup-selection + :test + (lambda (x y) + (and (equal (nnselect-artitem-group x) + (nnselect-artitem-group y)) + (eql (nnselect-artitem-number x) + (nnselect-artitem-number y)))))) (push (1+ seq) old-arts) (setq gnus-newsgroup-selection (vconcat gnus-newsgroup-selection (vector article))) -- 2.34.1.575.g55b058a8bb -- Andrew Cohen