* [PATCH] Fix bug in nnselect fetching new articles in a thread
@ 2022-03-16 3:52 Andrew Cohen
2022-03-17 10:40 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cohen @ 2022-03-16 3:52 UTC (permalink / raw)
To: emacs-devel
Thanks to Eli and the GNU copyright staff, my copyright issues have now
been solved. Eli has instructed me to send all patches to the list prior
to pushing to the repository, so I have a fair number of small changes
in the pipeline. This is the first:
* lisp/gnus/nnselect.el (nnselect-request-thread): Ignore the
Retrieval Status Value in comparing whether articles are the same.
---
lisp/gnus/nnselect.el | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/lisp/gnus/nnselect.el b/lisp/gnus/nnselect.el
index c880d79840..586dec65af 100644
--- a/lisp/gnus/nnselect.el
+++ b/lisp/gnus/nnselect.el
@@ -652,8 +652,15 @@ nnselect-request-thread
(lambda (article)
(if
(setq seq
- (cl-position article
- gnus-newsgroup-selection :test 'equal))
+ (cl-position
+ article
+ gnus-newsgroup-selection
+ :test
+ (lambda (x y)
+ (and (equal (nnselect-artitem-group x)
+ (nnselect-artitem-group y))
+ (eql (nnselect-artitem-number x)
+ (nnselect-artitem-number y))))))
(push (1+ seq) old-arts)
(setq gnus-newsgroup-selection
(vconcat gnus-newsgroup-selection (vector article)))
--
2.34.1.575.g55b058a8bb
--
Andrew Cohen
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix bug in nnselect fetching new articles in a thread
2022-03-16 3:52 [PATCH] Fix bug in nnselect fetching new articles in a thread Andrew Cohen
@ 2022-03-17 10:40 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2022-03-17 10:40 UTC (permalink / raw)
To: Andrew Cohen; +Cc: emacs-devel
Andrew Cohen <acohen@ust.hk> writes:
> * lisp/gnus/nnselect.el (nnselect-request-thread): Ignore the
> Retrieval Status Value in comparing whether articles are the same.
Looks good to me; go ahead and push.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-17 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-16 3:52 [PATCH] Fix bug in nnselect fetching new articles in a thread Andrew Cohen
2022-03-17 10:40 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).