From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: master 4a1f69ebca 2/2: Use (TICKS . HZ) for current-time etc. Date: Wed, 27 Apr 2022 15:20:16 +0800 Message-ID: <87r15j0z7z.fsf@yahoo.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39543"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org, emacs-orgmode To: Mark Barton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 27 09:22:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njc03-000A6u-PX for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Apr 2022 09:22:11 +0200 Original-Received: from localhost ([::1]:35394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njc02-0007j2-Gi for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Apr 2022 03:22:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njbyR-00070J-NS for emacs-devel@gnu.org; Wed, 27 Apr 2022 03:20:32 -0400 Original-Received: from sonic301-30.consmr.mail.ne1.yahoo.com ([66.163.184.199]:36884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njbyO-00041o-PX for emacs-devel@gnu.org; Wed, 27 Apr 2022 03:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1651044026; bh=/qEraMFO7LZrr9Ta+9eXADM/1aq8B1mizzzm33FN8Ag=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=svbDwU32U7M71Gbe9geDehwpQjPgSYWvC4piRTGc9eVpAKGNxJjXF1hLIMe3f/aDiUSg1Wr3l2f3ds+XuAsIb6JpA2KIF0w2E6ZQ+ckjgCvQfnwJLfzimQPJPHYQh4A8VlF7YT+Sditgbt7O/T6I9GiMJSeNmVUDkLHsu+90OoGALqXA7hHvkh2QZOO2upL0GuO+i5uApqJRc+ogcX0WLrmuRpXTsEIGvkrfTqg1jNBYYn4ogwSgFRgiTueivyb/wi7jdOBTtGXFd6ewo/M77wbQCBVpQmiyodAVJFYpfFZ2SpiqAOoI+5sDu5oOduA+R4xyOqOajacKpsRGXn5bhQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1651044026; bh=bFzixY+jYpEbX3lXo+H25wuqtTV5LGM/7//s+m2wZkJ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=pvO2rvIyqtGT2KllzjxFH0br69pXuNPpnK9Mhlcfpgx7qb6PvbwGJVCK5z7gM3Cy4vwcS78rykSarPYuR1lFLb0IAMubw2/ixNcPuPBYXuNG2UJzQBSaHs4ftz4RTl/IYRIFTmox6Tdnub9lYWNrBsxg3UXWHf1J/z0m7TL3+mnLbodQ4uZtwYFMnpqKfWxYITvMfH413229lPsjn0KJ3tc5USjnjGRXjTfeQ+ceQ+BGNQX/eMJ1c+XpedP5gzJTaqki+N8xZNz+hjwDjxOStngj7gFREdcXjCQs4HH45LG0cf3j+yvhCHBVqjPJ6Guy1OtGejpQ+QaU8xor+lbsTw== X-YMail-OSG: tkEqhokVM1lGRL125rBfdKuFmx8KfVMsihtn1d22CGVPiIzTb2kYLK5W9reKDGT VhEPZ.AncrsfBN7fmz2Zl2d36jCQ41d41.LftyFXBckmfEuoAn5O25hIrc7G7jwXqiadV8KSQ4M7 1wQD6GldbDaWPAyFaUOTenceT3FYnxQcluf7P_8ARgsS9yK3FnkK4EwsLwKiIXmYepFXwjZXlnvs f.cECpTZWOCa7k.a3XIUOm.7s900DOqz_inNznRaevGgOyjKUgnE1bDpk.JWq48BYQK_cOgg5CBH m8mVG_lb2S_Xv5L2k0a3ZBknMFzN_u.w83RIiDrbYpTOe6mXk52YdK71.VLap21jyzwwLHet3bLJ AcdMJsqA_6QTLKKATAO133WX1zyaOuHP.5IdqSOBlay8rqy5.9g3TMw.mn1PWdrMsUykOT7cpSsF 3XvusJp2af0xZ6FPsVZ_zEFIoqqXmcayIEN_Y7aPeMcF0AeylaBR1526J91D3EdrXhuq.pzCMSLF uMjWYi3tFKzJx6svmmSi6.M1PPMGu2U19mHut3i4cyXifH6EpXZM2rWMUOiZeyi78rLaqVue.3eO PVgI8QvnS81acvPSliTR_asiPdhirLoqo46lNCsCoDtZxWgRFYw57bZKhpCXBT7qTjRb6RB3g0WE 1AGtYOfcdColFm7L9gSawevcHkqBx6jdquksvgFWN2ftlUAHqv_Wn_H_VynFgJlT_dstl.a7HCJ5 tHcT9xySifauBKPSl5CH_Mh5.wNxKsSvYAxC1SqkOilNqauDD59Jjo5L_Eu1MVWXkoRQB1.EObmF egoRp1i6eUC4ZAIBgFz5jk1V03T9rflvFF8pOiqnFX X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Wed, 27 Apr 2022 07:20:26 +0000 Original-Received: by hermes--canary-production-sg3-795d7b4d54-mkmbd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID d243b4cdaf4cc9cc05a8ca9dcfe6b633; Wed, 27 Apr 2022 07:20:21 +0000 (UTC) In-Reply-To: (Mark Barton's message of "Tue, 26 Apr 2022 23:37:50 -0700") X-Mailer: WebService/1.1.20118 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.199; envelope-from=luangruo@yahoo.com; helo=sonic301-30.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288908 gmane.emacs.orgmode:144780 Archived-At: Mark Barton writes: > The change also breaks org-file-newer-than-p function that triggered > the debugger while loading my init that uses org babel. I was able to > use the example of the patch that Paul Eggert provided earlier for the > desktop-save to add the time-convert to =E2=80=9Cfix=E2=80=9D org-file-ne= wer-than-p as > shown below. Not positive that I needed to change it in both places, > but it works for me now on macOS Monterey. > > modified lisp/org/org-macs.el > @@ -264,8 +264,8 @@ org-file-newer-than-p > ;; (e.g. HFS+) do not retain any finer granularity. As > ;; a consequence, make sure we return non-nil when the two > ;; times are equal. > - (not (time-less-p (cl-subseq (nth 5 (file-attributes file)) 0 2) > - (cl-subseq time 0 2))))) > + (not (time-less-p (cl-subseq (time-convert (nth 5 (file-attribute= s file)) 'list) 0 2) > + (cl-subseq (time-convert time 'list) 0 2))))) Isn't the fact that changes are needed in multiple pieces of in-tree code a wake-up call demonstrating it's too early to change the default time format?