From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 242a4b49cb: Minor cleanups to X drag-and-drop code Date: Sun, 22 May 2022 15:50:35 +0800 Message-ID: <87r14mqa44.fsf@yahoo.com> References: <87v8tyf434.wl-jashank@rulingia.com.au> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35820"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Emacs development list To: Jashank Jeremy Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 22 09:52:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nsgNv-000909-Bq for ged-emacs-devel@m.gmane-mx.org; Sun, 22 May 2022 09:52:19 +0200 Original-Received: from localhost ([::1]:56496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nsgNu-0005UN-6Z for ged-emacs-devel@m.gmane-mx.org; Sun, 22 May 2022 03:52:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsgMS-0004iY-AH for emacs-devel@gnu.org; Sun, 22 May 2022 03:50:48 -0400 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:41835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nsgMQ-0005fp-6m for emacs-devel@gnu.org; Sun, 22 May 2022 03:50:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653205843; bh=vDjMrqbcz4kuXIlyEl3AiHxc650wgvUe06pwwvKigvA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=G/5Ww4isjW8YsMUAw0mVXMUotwEmtuincEXSR5L7BCrvv7DkrgCWaCQo45YxFzGAgDuUd3ORvpyK/mKw2Tu8lcZB6bVv1+dJpVw3iNWklprhJOY7X7Dd7y9gs0kqhnBcdFIPDv2CKwoqtOWkxEr58/jUZ0yIBGCGHqBV2QvLlxOe+a5+ar8/jSUl9MFyNYdusnXD+tzowr0LMc2t4Qm0PGWKUvnaxgtRdCOUPJyBjRdf24I98uO94LtDSuwK4ukG/mYuLD+sZq0+GRXqe8Wa5EZicuv6+Ctr5NIvadNhmgh78P1NU0Oh2Ig1A0helpWHWDwpiLZkWrOLQtzkp7pAdw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653205843; bh=6c4vjjQU16oNlG4fpmquQWh+NWW/u/XY1XKV7gkZ28j=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=NywVcMdA6mw27vWoCDovyKnIAWGW3UXKfvYMe2lx5ekW1DBJ+dpco1Muy0iz4JIu+XdY6tTI9BqMaeH2N4X/oaPSJuPHDeQnggSFlTD15jOMuQnp0qQqf/sASKgNki/Qp7XDtcgHrthzd+YM+zLdJ7mUA4LiXfQcX3yADU1P6NNvJ4bAq7wn++gHU8/Hh3/yPRzIJTwRuPDwBd/jePRZnHIdEzbU293ul6+KwOtg9yg0+U1BPAj5b8G0D/16AMXNVRaWJFWc44Ae+cGXA9hrvCGAakOYTKduNtf9OVEEyIQVjF2SxEr59IADMY8TfuICC+8YABWNBTE/70kKrHtjsQ== X-YMail-OSG: Q3NkzNMVM1lzRCg3mlDMjyZEItlp1YG49GunN4Wu0flOYq2y_QZ3VzzTDpeo35c oraO244Bcl_zrN2tb5XKfZRb8.hmOY1hmBTpv8N.2fcOumYcqsbmdb7P_TgI8Q3X1.YmgVvoCYcw XZ27s3SsYITIrTV._YioDTinmOCx7CSq7QSXMLgD8VEKaWHIDM1Q_x7KCo6sLNibbLxVUINuPMkd G.GbMoRLkqULx35kpYt5yOuriukojIKVhJ10OEL2FsZPlL247.1_rjc2VuXtBdqLZDNSNI31E9zS KTxd51lsiYJcpqhTW5zCCSmJ0oVqdFJH5aEK2PH29mP3CTUWejOoaeC6Bn_9BMBw0muSHcNzF1qY bhBkru1mGyvqej0onZp1pPusYntNuwg.W7N0W6oeYnTOcXYAqm.Npm88bLSD82lj9sXPKuzOoHP1 r.D8EJ1WTk2C9hlaR1zTmqGaRBxSDOdREE2fgBV8Rg6l.E1C6phuaZkJrN3BRm0gsheDuL_6uPad kimXXrDNs2lm2npzHYeeiSUwjK6YG6NQ.GASTsegzMDh0OQgwRumvPxB9Bi4zq6cHoDWMke9zyja z0XD8UDDCPKIf6SkB9EZMNURqUKv.2N1Fk.DPkZLasAZoXl.hjUz2.YPE3Kv7jAZUr3udi3ffzvV jI55HCbHvK0KsrPfpzsDh2m.zoAKK8kJj2Ps3h0RwIwRlBj_ntiWc2Opw4PCQkviFuKwvieldKfY KCIATH4dvqGKSsLsVBMKF9ExvdH_RPeVSNgIutMm2r821PqtsYdK.j7Er5MVo6QL5AaOoUmdvWJq ztED2AOP6yyheNzGHo3IWDe_qjNW0nvGnBSOLAjRtR X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Sun, 22 May 2022 07:50:43 +0000 Original-Received: by hermes--canary-production-sg3-7959d4d9bd-bjkcg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 633f51b2187a87ed51f5ff1726c3ec47; Sun, 22 May 2022 07:50:40 +0000 (UTC) In-Reply-To: <87v8tyf434.wl-jashank@rulingia.com.au> (Jashank Jeremy's message of "Sun, 22 May 2022 16:56:15 +1000") X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.31; envelope-from=luangruo@yahoo.com; helo=sonic307-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290076 Archived-At: Jashank Jeremy writes: > Whilst chasing down the build failure against e465ea816d, I observed > some compiler warnings related to this patch: > > .../emacs/src/src/xterm.c:1994:7: warning: variable 'data' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > if (rc) > ^~ > .../emacs/src/src/xterm.c:2016:7: note: uninitialized use occurs here > if (data[1] > XM_DRAG_PROTOCOL_VERSION) > ^~~~ > .../emacs/src/src/xterm.c:1994:3: note: remove the 'if' if its condition is always true > if (rc) > ^~~~~~~ > .../emacs/src/src/xterm.c:1977:16: note: initialize the variable 'data' to silence this warning > uint8_t *data; > ^ > = NULL > > This looks like a plausible issue --- XGetWindowProperty looks to be > fallible, and in the event it fails we're potentially dereferencing an > uninitialised value. I suspect the check introduced in this commit > should be within the immediately preceding region; however, I do not > know what the implications of such a change would be, and thus won't > concretely suggest one. Silly compiler. If rc is true, tmp_data is always initialized.