From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Tree sitter support for C-like languages Date: Sun, 13 Nov 2022 14:02:30 +0100 Message-ID: <87r0y7nh21.fsf@thornhill.no> References: <87tu36em9t.fsf@thornhill.no> <45FD2F78-F15B-488B-9348-A8E298D8AD35@gmail.com> <87v8nmyqqp.fsf@thornhill.no> <834jv4nz2g.fsf@gnu.org> <871qq8hsj1.fsf@thornhill.no> <83iljklzmo.fsf@gnu.org> <87v8nkgcqj.fsf@thornhill.no> <87sfiogcbm.fsf@thornhill.no> <83pmdrkyj7.fsf@gnu.org> <87v8njw5th.fsf@thornhill.no> <83leofkwjm.fsf@gnu.org> <963E740B-B9BA-49E3-A64E-501394DFE41A@thornhill.no> <83h6z3ko8l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16967"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 13 14:03:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ouCdk-0004AM-Kl for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Nov 2022 14:03:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouCdK-0002Lw-UK; Sun, 13 Nov 2022 08:02:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouCdH-0002KW-EP for emacs-devel@gnu.org; Sun, 13 Nov 2022 08:02:44 -0500 Original-Received: from out0.migadu.com ([2001:41d0:2:267::]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouCdD-00089q-R0; Sun, 13 Nov 2022 08:02:42 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1668344556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n60Sl7bgRsqriDvqVth1/civmcv1w59uWb0PZS9ikJ0=; b=Fsr5AQxUu8xvxhQRNOnopHm5VK2HKmEJpibGh95zLF8GYNsRMAuYUHQUIBxYRSTUclYt0c nOHXw6FXSsvjcVHqTO0sDFWrrOIYHIbzzlMwdTNeabDnrpBEdaH8+nKceLnZ/u6jyBCcVv CQPVuG/aETlC0gUt3j8QTeFy/ufqycgQoKBELGgWBDnfFKDHztzW2WlR86FhtpM8i0ac7t 919hcwP2txUE9VPKdBgSw0QZGN4/9lz2pMWKJ2w/KLjtQEcrN72/zSqfsKjz0MHGfz21AX gZlEtfO90KIJWoLs2p0HoCpesT+vSMSLbeYnjDIioPFu/KG4F5BzhW/Xv+NKCA== In-Reply-To: <83h6z3ko8l.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299719 Archived-At: Eli Zaretskii writes: >> Date: Sun, 13 Nov 2022 11:13:24 +0100 >> From: Theodor Thornhill >> CC: casouri@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca >> >> >> I think the best solution is just to remove the >> >> >> >> ``` >> >> :language mode >> >> :override t >> >> :feature 'error >> >> '((ERROR) @font-lock-warning-face) >> >> ``` >> > >> >What are the downsides of removing this? what will we lose? >> > >> >> Absolutely nothing. Only the yellow color. > > Which yellow color? > > And if we lose nothing, why was this in the code to begin with? what > was the thought behind using it? The warning face. My thinking was merely that identifying syntax errors could be useful, but I now believe this causes more noise and confusion rather than being a helpful tool. So there's no need to use it. These error-nodes can be seen with 'treesit-inspect-mode' for those interested anyways.