Re: server.el test failures

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Mon, 27 Feb 2023 18:50:20 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Cc: Paul Eggert <eggert@cs.ucla.edu>,  emacs-devel@gnu.org
    >> Date: Mon, 27 Feb 2023 17:40:16 +0100
    >> 
    >> I can make server-tests fail 100% on master and emacs-29 on Debian by
    >> running the tests from inside emacs using vterm. I commented out all
    >> the tests except server-tests/server-force-stop/keeps-frames
    >> 
    >> make -C test server-tests
    >> make: Entering directory '/home/rpluim/repos/emacs/test'
    >> make[1]: Entering directory '/home/rpluim/repos/emacs/test'
    >> ELC      lisp/server-tests.elc
    >> GEN      lisp/server-tests.log
    >> Running 1 tests (2023-02-27 17:35:01+0100, selector `(not (or (tag
    >> :unstable) (tag :nativecomp)))')
    >> make[1]: *** [Makefile:174: lisp/server-tests.log] I/O possible
    >> make[1]: Leaving directory '/home/rpluim/repos/emacs/test'
    >> make: *** [Makefile:240: lisp/server-tests] Error 2
    >> make: Leaving directory '/home/rpluim/repos/emacs/test'
    >> rltb:~/repos/emacs (master *)> 

    Eli> It's probably bogus, or the test is unstable, but just so we don't
    Eli> give up easily: can you show a C and Lisp backtrace from the SIGIO
    Eli> signal handler when it gets the signal in this case?

Iʼd love to, but our signal handler never gets called:

(gdb) b deliver_process_signal
Breakpoint 3 at 0x19d47e: deliver_process_signal. (2 locations)
(gdb) r
Starting program: /home/rpluim/repos/emacs/src/emacs --module-assertions --no-init-file --no-site-file --no-site-lisp -L "
:."  \
  -l ert  -l lisp/server-tests.el \
  --batch --eval '(ert-run-tests-batch-and-exit (quote (not (or (tag :unstable) (
tag :nativecomp)))))' 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7ffff129d700 (LWP 783192)]
Running 1 tests (2023-02-27 18:45:41+0100, selector `(not (or (tag :unstable) (tag :nativecomp)))')
[Detaching after vfork from child process 783193]
[New Thread 0x7ffff0992700 (LWP 783194)]
[New Thread 0x7fffeba46700 (LWP 783195)]
[Thread 0x7fffeba46700 (LWP 783195) exited]
[Thread 0x7ffff129d700 (LWP 783192) exited]
[Thread 0x7ffff22f8040 (LWP 783187) exited]

Program terminated with signal SIGIO, I/O possible.
The program no longer exists.

This is because we only install a SIGIO handler for interactive
sessions, so when I change that I get

Thread 1 "emacs" hit Breakpoint 3, deliver_process_signal (sig=29, 
    handler=0x5555556d1440 <handle_input_available_signal>) at sysdep.c:1726
1726	  int old_errno = errno;
(gdb) bt
#0  deliver_process_signal (sig=29, handler=0x5555556d1440 <handle_input_available_signal>) at sysdep.c:1726
#1  0x00007ffff5718140 in <signal handler called> () at /lib/x86_64-linux-gnu/libpthread.so.0
#2  0x00007ffff530fd2f in __GI___poll (fds=0x7fffffffa8b8, nfds=1, timeout=-1)
    at ../sysdeps/unix/sysv/linux/poll.c:29
#3  0x00007ffff6d92d02 in  () at /lib/x86_64-linux-gnu/libxcb.so.1
#4  0x00007ffff6d94d7f in  () at /lib/x86_64-linux-gnu/libxcb.so.1
#5  0x00007ffff6d94e91 in xcb_wait_for_reply () at /lib/x86_64-linux-gnu/libxcb.so.1
#6  0x00005555556a629b in x_term_init
    (display_name=display_name@entry=XIL(0x555556013664), xrm_option=xrm_option@entry=0x0, resource_name=0x55555600f870 "emacs") at xterm.c:30964
#7  0x00005555556a96c7 in Fx_open_connection
    (display=XIL(0x555556013664), xrm_string=<optimized out>, must_succeed=XIL(0)) at xfns.c:7548
#8  0x00005555557a2f15 in exec_byte_code
    (fun=<optimized out>, args_template=<optimized out>, nargs=<optimized out>, args=<optimized out>)
    at bytecode.c:809
#9  0x000055555575d633 in Ffuncall (nargs=2, args=0x7ffff12b27c8) at eval.c:2997
#10 0x000055555575daf2 in Fapply (nargs=2, args=0x7ffff12b27c8) at eval.c:2625
#11 0x00005555557a2f15 in exec_byte_code
    (fun=<optimized out>, args_template=<optimized out>, nargs=<optimized out>, args=<optimized out>)
    at bytecode.c:809
#12 0x000055555575d633 in Ffuncall (nargs=3, args=0x7fffffffb5f0) at eval.c:2997
#13 0x000055555575d850 in Fapply (nargs=nargs@entry=2, args=args@entry=0x7fffffffb680) at eval.c:2668
#14 0x000055555575dbbc in apply1 (fn=<optimized out>, arg=<optimized out>) at eval.c:2884
#15 0x000055555575be04 in internal_condition_case_1
    (bfun=bfun@entry=0x5555557a5bb0 <read_process_output_call>, arg=XIL(0x7ffff0a64f33), handlers=handlers@entry=XIL(0), hfun=hfun@entry=0x5555557a5af0 <read_process_output_error_handler>) at eval.c:1498
#16 0x00005555557a86bb in read_and_dispose_of_process_output
    (coding=0x555555ff6090, nbytes=3395, chars=0x7fffffffb6d0 "-env PWD=/home/rpluim/repos/emacs/test -env OLDPWD=/home/rpluim/repos/emacs -env DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus -env GDMSESSION=gnome-xorg -env HISTIGNORE=&&:[&_]*:exit:ls:bg:fg"..., p=0xfffffffffffffffb) at process.c:6307
#17 read_process_output (proc=proc@entry=XIL(0x555556000065), channel=channel@entry=10) at process.c:6217
#18 0x00005555557afe11 in wait_reading_process_output
    (time_limit=time_limit@entry=0, nsecs=nsecs@entry=100000000, read_kbd=read_kbd@entry=0, do_display=do_display@entry=false, wait_for_cell=wait_for_cell@entry=XIL(0), wait_proc=wait_proc@entry=0x0, just_wait_proc=<optimized out>)
    at process.c:5901
#19 0x00005555555aae9b in Fsleep_for (seconds=<optimized out>, milliseconds=<optimized out>) at lisp.h:1164
#20 0x00005555557a2f15 in exec_byte_code
    (fun=<optimized out>, args_template=<optimized out>, nargs=<optimized out>, args=<optimized out>)
    at bytecode.c:809
#21 0x0000555555762797 in apply_lambda (fun=XIL(0x7ffff17d8845), args=<optimized out>, count=...) at eval.c:3105
#22 0x0000555555760e5d in eval_sub (form=<optimized out>) at eval.c:2590
#23 0x0000555555761b8d in Fprogn (body=XIL(0)) at eval.c:436
#24 prog_ignore (body=XIL(0x7ffff0a80b63)) at eval.c:447
#25 Fwhile (args=<optimized out>) at eval.c:1047
--Type <RET> for more, q to quit, c to continue without paging--c
#26 0x000055555576117a in eval_sub (form=<optimized out>) at lisp.h:765
#27 0x0000555555762d15 in Fprogn (body=XIL(0)) at eval.c:436
#28 Flet (args=XIL(0x7ffff0a80bc3)) at eval.c:1026
#29 0x000055555576117a in eval_sub (form=<optimized out>) at lisp.h:765
#30 0x0000555555762d15 in Fprogn (body=XIL(0x7ffff0a820a3)) at eval.c:436
#31 Flet (args=XIL(0x7ffff0a83ca3)) at eval.c:1026
#32 0x000055555576117a in eval_sub (form=<optimized out>) at lisp.h:765
#33 0x0000555555762d15 in Fprogn (body=XIL(0)) at eval.c:436
#34 Flet (args=XIL(0x7ffff0a83cd3)) at eval.c:1026
#35 0x000055555576117a in eval_sub (form=<optimized out>) at lisp.h:765
#36 0x000055555576146d in Fprogn (body=XIL(0x7ffff0a851b3)) at eval.c:436
#37 0x000055555576117a in eval_sub (form=<optimized out>) at lisp.h:765
#38 0x0000555555763287 in Funwind_protect (args=XIL(0x7ffff0a851d3)) at lisp.h:765
#39 0x000055555576117a in eval_sub (form=<optimized out>) at lisp.h:765
#40 0x0000555555762d15 in Fprogn (body=XIL(0)) at eval.c:436
#41 Flet (args=XIL(0x7ffff0a87b93)) at eval.c:1026
#42 0x000055555576117a in eval_sub (form=<optimized out>) at lisp.h:765
#43 0x00005555557630f5 in Fprogn (body=XIL(0)) at eval.c:436
#44 FletX (args=XIL(0x7ffff0a87bd3)) at eval.c:958
#45 0x000055555576117a in eval_sub (form=<optimized out>) at lisp.h:765
#46 0x0000555555763287 in Funwind_protect (args=XIL(0x7ffff0a87c03)) at lisp.h:765
#47 0x000055555576117a in eval_sub (form=<optimized out>) at lisp.h:765
#48 0x00005555557630f5 in Fprogn (body=XIL(0x7ffff0a780d3)) at eval.c:436
#49 FletX (args=XIL(0x7ffff0a780e3)) at eval.c:958
#50 0x000055555576117a in eval_sub (form=<optimized out>) at lisp.h:765
#51 0x000055555576203d in Fprogn (body=XIL(0)) at eval.c:436
#52 funcall_lambda (fun=XIL(0x7ffff0a75c53), nargs=0, arg_vector=0x7ffff12b2468) at eval.c:3235
#53 0x00005555557a30e1 in exec_byte_code (fun=<optimized out>, args_template=<optimized out>, nargs=<optimized out>, args=<optimized out>) at bytecode.c:811
#54 0x0000555555762797 in apply_lambda (fun=XIL(0x555555f7f0a5), args=<optimized out>, count=...) at eval.c:3105
#55 0x0000555555760e5d in eval_sub (form=<optimized out>) at eval.c:2590
#56 0x0000555555763830 in Feval (form=XIL(0x7ffff0a75dd3), lexical=<optimized out>) at eval.c:2363
#57 0x00005555557a2f15 in exec_byte_code (fun=<optimized out>, args_template=<optimized out>, nargs=<optimized out>, args=<optimized out>) at bytecode.c:809
#58 0x0000555555762797 in apply_lambda (fun=XIL(0x7ffff1ad0ff5), args=<optimized out>, count=...) at eval.c:3105
#59 0x0000555555760e5d in eval_sub (form=<optimized out>) at eval.c:2590
#60 0x0000555555763830 in Feval (form=XIL(0x7ffff1f07dbb), lexical=<optimized out>) at eval.c:2363
#61 0x000055555575bd77 in internal_condition_case (bfun=bfun@entry=0x5555556d1590 <top_level_2>, handlers=handlers@entry=XIL(0x90), hfun=hfun@entry=0x5555556d88e0 <cmd_error>) at eval.c:1474
#62 0x00005555556d1eb6 in top_level_1 (ignore=ignore@entry=XIL(0)) at keyboard.c:1141
#63 0x000055555575bcd1 in internal_catch (tag=tag@entry=XIL(0x103e0), func=func@entry=0x5555556d1e90 <top_level_1>, arg=arg@entry=XIL(0)) at eval.c:1197
#64 0x00005555556d1508 in command_loop () at lisp.h:1164
#65 0x00005555556d8493 in recursive_edit_1 () at keyboard.c:711
#66 0x00005555556d880c in Frecursive_edit () at keyboard.c:794
#67 0x00005555555a9e43 in main (argc=<optimized out>, argv=<optimized out>) at emacs.c:2530

Lisp Backtrace:
"x-open-connection" (0xf12b2850)
0xf1ad3f38 PVEC_COMPILED
"apply" (0xf12b27c8)
"window-system-initialization" (0xf12b2768)
"make-frame" (0xf12b26e8)
"server--create-frame" (0xf12b2670)
"server-create-window-system-frame" (0xf12b25b8)
"server-process-filter" (0xffffb5f8)
"sleep-for" (0xf12b24d8)
"sit-for" (0xffffccc0)
"while" (0xffffce40)
"let" (0xffffcf70)
"let" (0xffffd0a0)
"let" (0xffffd1e0)
"progn" (0xffffd2b0)
"unwind-protect" (0xffffd380)
"let" (0xffffd4b0)
"let*" (0xffffd5e0)
"unwind-protect" (0xffffd6b0)
"let*" (0xffffd7e0)
0xf0a75c60 Lisp type 3
"ert--run-test-internal" (0xf12b23f8)
"ert-run-test" (0xf12b2388)
"ert-run-or-rerun-test" (0xf12b2318)
"ert-run-tests" (0xf12b2290)
"ert-run-tests-batch" (0xf12b2238)
"ert-run-tests-batch-and-exit" (0xffffd980)
"eval" (0xf12b21c0)
"command-line-1" (0xf12b20b8)
"command-line" (0xf12b2040)
"normal-top-level" (0xffffdb50)

If I run that server test with the SIGIO handler installed it passes

Robert
--