From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: How to install documentation in sub-directory with Package VC? Date: Sun, 09 Apr 2023 21:55:15 +0000 Message-ID: <87r0ssoh4s.fsf@posteo.net> References: <87bkkvconh.fsf@posteo.net> <87o7oujqqp.fsf@posteo.net> <98f76116-4f5a-c225-3123-78c612ec64cb@protonmail.com> <875yb1gk55.fsf@posteo.net> <87cz4te31m.fsf@posteo.net> <877cun5psj.fsf@bernoul.li> <87mt3i93ex.fsf@posteo.net> <87lej0lx1j.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8827"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Okamsn , emacs-devel@gnu.org To: Jonas Bernoulli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 09 23:56:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pld19-00028F-EI for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Apr 2023 23:56:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pld0N-0001V2-7z; Sun, 09 Apr 2023 17:55:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pld0K-0001UZ-Oy for emacs-devel@gnu.org; Sun, 09 Apr 2023 17:55:20 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pld0I-00023p-J2 for emacs-devel@gnu.org; Sun, 09 Apr 2023 17:55:20 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9EF3424008F for ; Sun, 9 Apr 2023 23:55:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681077316; bh=sXTZFs8icStEgXtm1OqnpUaQYHXjXEXnHIlsSoCQOEg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=k14VpHEBkzDZHnli7vgO8OuVB7diEXq61ATW0UpAuNm7qa00o/h2npdmZfMywRAIk jzfp9MjbNOtI4Gd2uw6Urt1zvGjvSvCfFaAIEG4PrAPEPPKZcByT2lv97DTYvR9tJ6 SXClFrcagY6/j5mT5MnHnp63PpjASqNuSEr2WK+u4Mma15PAGzf+MurH1W1sD2qAe4 5bCN88viVoNBhcq7evs9Lgk0fXGz6fvEC/kKwfj9WJz5nRci7KrErPAY4gbgaxXVpB L1DlxEsbj4yyYL9vL1vdQvgj11QYtdFzlCDrUYIinxidZYiURXNyIIahJ8KvsqFV9U Cp0WZrSYgsaxw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Pvm9w1CH8z6trm; Sun, 9 Apr 2023 23:55:15 +0200 (CEST) In-Reply-To: <87lej0lx1j.fsf@bernoul.li> (Jonas Bernoulli's message of "Sun, 09 Apr 2023 20:39:52 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305214 Archived-At: Jonas Bernoulli writes: > Philip Kaludercic writes: > >>> We only provide :url, and where appropriate :branch, :vc-backend and >>> :maintainer. >> >> :maintainer is currently not used > > Removed. > > Could you please ping me when you add new properties? I don't see the point of adding support for it to package-vc, that is to say that I don't know what would want to make use of it. >> (TBH I am not sure what the point of it is in elpa-admin to begin >> with), > > Sending emails to a package's maintainer. It is used to send every > pushed commit for example. Every commit? From what it see being done in elpa-admin.el it is invoked when a package fails to build and on releases (as is the case when a maintainer is listed in the package header). >>> We don't set :doc or :lisp-dir (yet?). >> >> Do you think it could be possible to support :doc and :lisp-dir. IIUC >> the issue is that MELPA only accepts a list of files to include when >> bundling a package (:files) and the build system would have to infer >> what what is? > > Why is :doc needed? I think package-install simply runs makeinfo on all > texi files, but of course it can rely on them being at the top-level. I don't see that package-install attempts anything like that. > It might end up trying (and failing) to directly process gpl.texi and > similar. But still, cannot package-vc simply do that too? Sure, that can be done. There was just no need for that up until now considering that ELPA added :doc provides the information. > The value of :doc can also be an org file and we cannot just blindly try > to transcode *all* org files to texi. But Melpa doesn't support > exporting ort to texi, so packages distributed there cannot assume that > that happens. (I wish Melpa supported this and I actually implemented > it, but the main Melpa maintainers didn't want to merge it for security > reasons.) Hmm, understandable. As long as MELPA wouldn't install a manual in these cases, I think it is tolerable if package-vc doesn't do so either. > I am not sure determining :lisp-dir from :files on the archive's side, > is easier and/or more reliable than package-vc doing it itself based > solely on what it finds in the latest commit. In Borg I use "if lisp/ > exists, then use that, else use ./" and that works for 99% of all > packages. What package-vc does is check both "lisp" and "src" checking if they contain .el files. Good to know that this works well enough. > I think it would be better to first try to add some heuristics to > package-vc. If that doesn't work well enough, we can still later > make package-build generate more elpa-admin-style metadata. Yeah, it should all work well enough for now, I guess the only way to improve this is to deal with real-world edge-cases that are discovered over time. -- Philip Kaludercic