From: Ihor Radchenko <yantar92@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: juri@linkov.net, emacs-devel@gnu.org
Subject: Re: Is it valid to call isearch-filter-predicate outside isearch?
Date: Wed, 31 May 2023 12:56:16 +0000 [thread overview]
Message-ID: <87r0qwk6bz.fsf@localhost> (raw)
In-Reply-To: <83edmwfz6p.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> It would be nice if the docstring of `isearch-filter-predicate'
>> mentioned that it might be called outside isearch-mode.
>
> I don't really understand what you are asking here to document. From
> reading the discussion, it sounds like you set
> isearch-filter-predicate to a function that relies on some
> (unidentified) isearch hooks to undo its side effects? And you did
> that without studying all of the existing callers of
> isearch-filter-predicate? Not sure how documentation could have
> solved this for you.
I expected `isearch-filter-predicate' to be only used by isearch in
isearch-mode. And thus I expected `isearch-mode-end-hook' to be called
later.
Isn't it a natural expectation?
> In general, a predicate is not expected to have side effects, it is
> expected to return a boolean value and leave everything else intact.
>
> (I also don't understand what does isearch-range-invisible have to do
> with this.)
`isearch-range-invisible' can modify `isearch-opened-overlays' and
`isearch-hidden' by side effect.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-05-31 12:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 14:10 Is it valid to call isearch-filter-predicate outside isearch? Ihor Radchenko
2023-05-22 18:12 ` Juri Linkov
2023-05-31 10:08 ` Ihor Radchenko
2023-05-31 12:44 ` Eli Zaretskii
2023-05-31 12:56 ` Ihor Radchenko [this message]
2023-05-31 14:21 ` Eli Zaretskii
2023-05-31 14:38 ` Ihor Radchenko
2023-05-31 15:22 ` [External] : " Drew Adams
2023-06-01 8:10 ` Ihor Radchenko
2023-05-31 23:10 ` Michael Heerdegen
2023-06-01 11:48 ` Ihor Radchenko
2023-06-01 23:30 ` Michael Heerdegen
2023-06-02 8:58 ` Ihor Radchenko
2023-06-01 6:38 ` Juri Linkov
2023-06-01 11:44 ` Ihor Radchenko
2023-05-31 23:17 ` Michael Heerdegen
2023-06-01 5:55 ` Eli Zaretskii
2023-06-01 23:13 ` Michael Heerdegen
2023-06-01 0:40 ` Michael Heerdegen
2023-06-01 11:42 ` Ihor Radchenko
2023-06-01 16:21 ` Juri Linkov
2023-06-02 8:56 ` Ihor Radchenko
2023-06-01 23:22 ` Michael Heerdegen
2023-06-02 9:07 ` Ihor Radchenko
2023-06-02 13:36 ` [External] : " Drew Adams
2023-06-02 23:06 ` Michael Heerdegen
2023-06-03 8:35 ` Ihor Radchenko
2023-06-04 0:06 ` Michael Heerdegen
2023-06-17 13:05 ` Ihor Radchenko
2023-06-18 2:48 ` Michael Heerdegen
2023-06-18 11:31 ` Ihor Radchenko
2023-06-04 2:06 ` Michael Heerdegen
2023-06-18 10:31 ` Ihor Radchenko
2023-06-18 21:39 ` Michael Heerdegen
2023-06-19 10:44 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0qwk6bz.fsf@localhost \
--to=yantar92@posteo.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).