From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tony Zorman Newsgroups: gmane.emacs.devel Subject: Re: package-vc support for :files keyword Date: Mon, 18 Sep 2023 16:43:26 +0200 Message-ID: <87r0mviltd.fsf@hyperspace> References: <87ttrshrib.fsf@hyperspace> <871qev6e53.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18234"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 18 16:53:34 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiFcz-0004Rb-1a for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Sep 2023 16:53:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiFZx-0003Ql-K1; Mon, 18 Sep 2023 10:50:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiFTN-0004Z7-6W for emacs-devel@gnu.org; Mon, 18 Sep 2023 10:43:37 -0400 Original-Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1qiFTK-00032c-Gi for emacs-devel@gnu.org; Mon, 18 Sep 2023 10:43:36 -0400 Original-Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4Rq6ww3mLLz9sTs; Mon, 18 Sep 2023 16:43:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1695048208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RlPfMoi0tMpgMlwKOrhaU9YhnTaQW9p4nWdrVro9+bo=; b=J1ksUmkZLGQi/VO0MAGOKK59ahc/lxsO0fr0C9+vdr/nTTQvQqskhrxmQzppqsHDvT4Rm9 jexvc0ydyGgDFRhEpG8vJsY56830plrViecUdxVghKsgpzr0i1BR2LLN/IMTJ5yhti52JI fWsNTu7JDD5xGz0KP9JySOrhH7bt5nk7EmsIZK0tTjwJMwyxvR1NX9/z9zeZuyng8MQPi7 bGY+1MVa8kBaDq/Ja4clrByZd5eIPWVchlpesOlscLzbNqoH3B5eGv62/IQo6W1zQZ393v f53Xv5/XonT+hCoqc+7TtU+aUAG0Hsai/WiBeVuRS4a1SftlGiblXbryo9oBjQ== In-Reply-To: <871qev6e53.fsf@posteo.net> X-MBO-RS-META: a8m7tu6hf5erwbb36cuq6z8pa3e3ra5a X-MBO-RS-ID: 0b0355da6f8597d14f5 Received-SPF: pass client-ip=2001:67c:2050:0:465::202; envelope-from=tonyzorman@mailbox.org; helo=mout-p-202.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 18 Sep 2023 10:50:03 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310704 Archived-At: On Mon, Sep 18 2023 09:10, Philip Kaludercic wrote: > Tony Zorman writes: >> here's an idea: why not create e.g. a variable to decide when >> :shell-command is executed? Moving the execution to right after cloning >> the repository, instead of before building documentation, would enable >> one to easily emulate :files directives, as well as other keywords that >> need to be executed before things actually get built. >> >> Alternatively one could have a second :shell-command like keyword. > > My issue with the first idea would be that this would create a greater > discrepancy between what elpa-admin and package-vc do. So if anything, > I think only the second option, e.g. :early-shell-command, would be > viable. Fair enough. > In both cases, what would you imagine that the command would do? If it > just calls "rm foo.el bar.el ...", then we have an issue when upgrading, > because there would at least be a merge conflict any time the other > files are modified upstream. Upgrading isn't easy the way it is, but > raising the necessity for manual intervention every time is something > I'd like to avoid. I think that $ rm foo.el $ git update-index --assume-unchanged foo.el should work. It should merge cleanly (I've tried this out just now, and it worked, but I may have overlooked something). If it's part of the package description, then updating should work out of the box, since package-vc-upgrade also calls package-vc--unpack-1, which would execute the respective :early-shell-command again. > Also, what would a :early-shell-command be used for > on the ELPA build server? That I don't know, I've never consciously looked at the ELPA build server. -- Tony Zorman | https://tony-zorman.com/