From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Permanently fix org versioning breakage during builds? Date: Sun, 24 Dec 2023 17:16:57 +0000 Message-ID: <87r0jb34hi.fsf@localhost> References: <25989.50971.995591.385250@google.com> <87a5q0dc9m.fsf@localhost> <87edfbbyzm.fsf@localhost> <875y0n4px0.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6527"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "T.V Raman" , emacs-devel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 24 18:14:55 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rHS3z-0001a0-Dt for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Dec 2023 18:14:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rHS36-0007e0-4p; Sun, 24 Dec 2023 12:14:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHS31-0007cY-Lr for emacs-devel@gnu.org; Sun, 24 Dec 2023 12:13:56 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHS2y-0004aR-Hv for emacs-devel@gnu.org; Sun, 24 Dec 2023 12:13:55 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8598C240027 for ; Sun, 24 Dec 2023 18:13:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1703438029; bh=tVYLbBOHQUeB/B2JHn0dM0ENhij11BfemZqQcJAgOXU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=SFySD33BjUBwfTISq4xWpsw0d+FlX752cGQQKrtQQTKI74uYkUbLHDK0g+pHy/Tae rBFWxCkVIqSd0qGV2MrvGX2C9DBVFtUHB2zrp/9N7BEmV35YsQaNYZhQnPSfiqAogT Y2+yij/1clVwFsp5j/wOlOZ82OBYtsJqLo0PSmI+m49QsuW/20Hr3Lp9urhJXU4cYI G+RNql8cVCGQ2p0Rj4w358aZzmLAMgWH5uqxfSm1LExHoJR6fvEdr7dKCK4rZehBQp gDrazwVjBRnsNatXg0bCJFxmUb+YmCBN/FI6P59VbprnjbyEVVRideLZC/CgdbrqLN S9GKfpd1N/QJw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Syngd16Mkz6txT; Sun, 24 Dec 2023 18:13:49 +0100 (CET) In-Reply-To: Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314152 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > On Sun, Dec 24, 2023 at 4:32=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > >> >> No, it didn't, I'm afraid. If you know one of these macros (you alluded >> earlier to "some macros"), type its name here, please. > > IIn the absence of examples (so far), I went looking for one myself. > I found 'org-export-with-buffer-copy' in lisp/org/ox.el. It's expanded > in ox-html.el and ox-publish.el in the same directory. It is not about a specific macro. Any macro may be broken this way. There may be confusion about `org-assert-version' macro vs. all other macros. The former is my attempt to detect potential breakage of the latter. > [ Tangent: one thing I notice is that the expansion in ox-html.el is > buggy. It evaluates the keyword arguments to the macros multiple times > for no effect. The solution would be to change the macro calling > convention to be: > > (cl-defmacro org-export-with-buffer-copy ((&key to-buffer drop-visibility > drop-narrowing drop-contents > drop-locals > &allow-other-keys) &body body) > ...) May you elaborate? > Anyway, let's apply the "CALL-WITH" technique: > > (cl-defmacro org-export-with-buffer-copy ( &rest body > &key to-buffer drop-visibility > drop-narrowing drop-contents > drop-locals > &allow-other-keys) > "..." > `(org-export--call-with-buffer-copy (lambda () ,@body) AFAIU, this technique will prevent compiler optimizations, won't it? > As a bonus, no more "with-gensyms" needed or hairy commas. Easier > debugging. I did a make -C test org/tests but that doesn't have any > good tests and I don't know how to exercise the "publish" and "html" > functionality, so I ask that you test. We do not sync Org tests with Emacs tree. They are only a part of Org repository: https://git.savannah.gnu.org/cgit/emacs/org-mode.git/ Also, do note that development version of Org mode is not what you see in Emacs tree - Emacs has only stable version. Your patch will not apply on the latest Org main branch. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at