From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.devel Subject: Re: discoverability, better defaults and which-key in Emacs Date: Thu, 08 Feb 2024 07:16:56 +0530 Message-ID: <87r0hnohgv.fsf@gmail.com> References: <874jetaxri.fsf@jeremybryant.net> <87le84oqbd.fsf@yahoo.com> <87plxdpsxw.fsf@posteo.net> <87r0hridvr.fsf@posteo.net> <5dd3d04c-c0eb-43fe-b7c2-957f80261ea3@gutov.dev> <87eddqiw84.fsf@posteo.net> <32071337-c91d-46ad-bb9b-10b8d0c83965@gutov.dev> <86h6ikzc38.fsf@gnu.org> <1056a72d-af5c-487e-be33-67522fe47d17@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12792"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , justin@burkett.cc, philipk@posteo.net, luangruo@yahoo.com, jb@jeremybryant.net, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 08 02:47:50 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rXtW2-00034k-5w for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Feb 2024 02:47:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXtVJ-0003hE-DT; Wed, 07 Feb 2024 20:47:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXtVG-0003go-Vi for emacs-devel@gnu.org; Wed, 07 Feb 2024 20:47:02 -0500 Original-Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXtVF-0007uu-Bw; Wed, 07 Feb 2024 20:47:02 -0500 Original-Received: by mail-pj1-x1044.google.com with SMTP id 98e67ed59e1d1-2906773c7e9so947962a91.1; Wed, 07 Feb 2024 17:47:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707356819; x=1707961619; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cjF96IoEaXQOgn6Xuknl3E0U2jFqoMOpSrTmSaiKUbE=; b=ISjARWNCr0trJIYyjqOG4+Lw/d+l6ozY09U+nyV/3b0gDY0ps7XHo5j3ZuSGlgpceu ZaLONqOsqOes9qtx5w5MzYH3s3iDW/9/oJNef/B+UiSz3j8wojDesYzmgO3UhZ6RQucW GqMA+yrQ6lPlA/NTJPtqcKWSvoJX7Rcw16YeCUGafeNjTybccgQCfPZz1Tg3oT+EIRfk UV31mgiAbhvf3Nbyah+r5H9pOjcu1EAXjuuPNkXfL5nDZFGms6mrtWhewgadaQs+x2Uu aGpvWP30yHTM2ZZC0WVufsnckMnIWC2DMsztjLa5fVQRRQVwduWQyIaI4RWc56wedG9r Gwug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707356819; x=1707961619; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cjF96IoEaXQOgn6Xuknl3E0U2jFqoMOpSrTmSaiKUbE=; b=H68ILEU+tABw6/xaelOgWoNc6goDNuYBmZWHp17k/DHkqFIp4marw0a072fLCoiZoQ VLmIINNVAZ3FxKBSecjisoMcn2SfYdY2XfoC6M+4TwxyZdgLw2BxJ9biFpMUGdlZoKu0 yZx5oN6+NwK0tvDn+pkyoRE9FztQLYNNcDmSpACegKcwRhFTt2fzFuXG15an1ntvRFMi 4glsol6Ca/ndRGjLs8WKgjoxjFLHyishDROVZEGtnKEAVTMdpKCw9QySLwbWO/odqbCv 6S0gQ9i3r/w2mgxAZhpfU3XbtVdjWHpVkAwV3z9qO8TrIu7Q1tcJdUbFoWPh7BYVDMOa cKwg== X-Forwarded-Encrypted: i=1; AJvYcCWz9CoQpMsqmpy9c4g1fno5DRt3J0SIat1J+9Veixhq/MX/RDiqybIX+7PFD2aoroDEBCMY4q2tENHpx7ELldQ19VAj X-Gm-Message-State: AOJu0Yz1h/9TAZf/jYTZRGoKSNIMk0rOzZOZcpkbnu5Ykh9Sx5UWze9h ZylmnI86JKksPsA6CHnvJyfcJM/syJtP00q2VfBF2RatPFmduNkoSe0DXK59MYY= X-Google-Smtp-Source: AGHT+IGZqCnF31RjGZY1MSDAWqsy0Kj0K8SLnfBIAM87VS3QUw2Why7SsCyxhQKtIGuEfVfJEFZzdg== X-Received: by 2002:a17:90a:d241:b0:296:f876:23a2 with SMTP id o1-20020a17090ad24100b00296f87623a2mr587552pjw.30.1707356819194; Wed, 07 Feb 2024 17:46:59 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUbufqxRYhmDRPXaNO3oSy0BCPqGTkxBK2Zf5g4ux8ehbbLKP0t1asjMSNSjvv3w4Lvv+7jcKr3RqX2yJsHxoj3x3lHOnFopw1Zd6/NFHXRfSNU8KQPa/scFEjb48irW1mAeTGqRS9snd2LC8sp5REfHfq6EaKDqqB/UXrvmUov2Mgo6VTW+Rdx4n57khlM5FKlIQQ= Original-Received: from localhost ([1.7.159.70]) by smtp.gmail.com with ESMTPSA id gz21-20020a17090b0ed500b00296dd7eff41sm126957pjb.9.2024.02.07.17.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 17:46:58 -0800 (PST) In-Reply-To: <1056a72d-af5c-487e-be33-67522fe47d17@gutov.dev> (Dmitry Gutov's message of "Wed, 7 Feb 2024 20:31:04 +0200") Received-SPF: pass client-ip=2607:f8b0:4864:20::1044; envelope-from=visuweshm@gmail.com; helo=mail-pj1-x1044.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316004 Archived-At: [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=AA=E0=AE=BF=E0=AE=AA= =E0=AF=8D=E0=AE=B0=E0=AE=B5=E0=AE=B0=E0=AE=BF 07, 2024] Dmitry Gutov wrote: > [...] > diff --git a/src/keyboard.c b/src/keyboard.c > index 1f7253a7da1..6d3db5ab615 100644 > --- a/src/keyboard.c > +++ b/src/keyboard.c > @@ -589,6 +589,15 @@ echo_dash (void) > AUTO_STRING (dash, "-"); > kset_echo_string (current_kboard, > concat2 (KVAR (current_kboard, echo_string), dash)); > + > + if (echo_keystrokes_help) > + { > + AUTO_STRING (help, " (\\`C-h' for help)"); ^^^^^^^ Shouldn't this part use the value of help-char instead? (There's also the complication with help-form.) > + kset_echo_string (current_kboard, > + concat2 (KVAR (current_kboard, echo_string), > + calln (Qsubstitute_command_keys, help))); > + } > + > echo_now (); > } >=20=20 > @@ -13228,6 +13237,10 @@ syms_of_keyboard (void) > If the value is zero, don't echo at all. */); > Vecho_keystrokes =3D make_fixnum (1); >=20=20 > + DEFVAR_BOOL ("echo-keystrokes-help", echo_keystrokes_help, > + doc: /* Non-nil means append small help text to the unfinished c= ommands' echo. */); > + echo_keystrokes_help =3D true; > + > DEFVAR_LISP ("polling-period", Vpolling_period, > doc: /* Interval between polling for input during Lisp execution. > The reason for polling is to make C-g work to stop a running program.