From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jeremy Bryant Newsgroups: gmane.emacs.devel Subject: Re: Incorporate package macrostep into Emacs core Date: Mon, 18 Mar 2024 22:58:02 +0000 Message-ID: <87r0g79mh1.fsf@jeremybryant.net> References: <87zfvl8r4e.fsf@jeremybryant.net> <874jdspsqb.fsf@bernoul.li> <877cio8fzf.fsf@jeremybryant.net> <87y1b46vhg.fsf@jeremybryant.net> <878r336lvb.fsf@jeremybryant.net> <86y1b1p1ni.fsf@gnu.org> <87y1b0mi4b.fsf@jeremybryant.net> <8734sobkdj.fsf@jeremybryant.net> <86sf0n4sfq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4430"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org, j.j.oddie@gmail.com, stefankangas@gmail.com, jonas@bernoul.li To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 18 23:59:12 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rmLwk-0000sz-P5 for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Mar 2024 23:59:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmLvt-0004LT-Aj; Mon, 18 Mar 2024 18:58:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmLvq-0004JM-3i for emacs-devel@gnu.org; Mon, 18 Mar 2024 18:58:14 -0400 Original-Received: from out-174.mta1.migadu.com ([95.215.58.174]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmLvn-0000i6-Ga for emacs-devel@gnu.org; Mon, 18 Mar 2024 18:58:13 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1710802685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tz/ITvj7X4kftWyTXtLK99yKpiiFegCMM7Z7eOPYFVQ=; b=uFeiQ2LAvnzaXgnY/gkdtEScsNsyyZY1x5Zut7mVY/D6j4QU/VxHJqoiEWc06sUlsxeIkH 6OBSXqQr/TV2UGaRSxFsZLFq/4nq+BQPHZDYzgppgjQ/KS6TtRIyUQCylTtH3ywwZ9c/fB HfnTYEl9NXCpPKmkhdDuhBxSmMcB9yuPNHZTsNw3lWIbs/G41FbqeDYp/7p7yvw6kf9uGr urnAO7/avFT6JRmr8y1iWLYocNFS6E0z51RpHZpMqmjO90tdiQa7SUdQeOVAvyMv1L83tt RhzAeZa8i4Azc5VGo064iTUC1rgUe64/ggPtl1GX5y7NbqyYWiHhieVCBUzj1A== In-Reply-To: <86sf0n4sfq.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 18 Mar 2024 14:48:09 +0200") X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=95.215.58.174; envelope-from=jb@jeremybryant.net; helo=out-174.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317171 Archived-At: Eli Zaretskii writes: >> From: Jeremy Bryant >> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org, j.j.oddie@gmail.com, >> stefan@marxist.se, stefankangas@gmail.com, jonas@bernoul.li >> Date: Sun, 17 Mar 2024 21:48:08 +0000 >> >> Manual? >> Should the documentation for macrostep be included in the Emacs Lisp >> manual section Macros? > > Yes, I think so. > > Please also provide a suitable entry for NEWS. > >> Code? >> The main file is attached for convenience, from the orphanage upstream >> (https://github.com/emacsorphanage/macrostep). >> Are any changes needed before this is merged into Emacs? >> I volunteer to write some code towards this, please let me know. > > Please add :version tags to all the defcustom's and defface's. > >> (define-obsolete-variable-alias 'macrostep-mode-keymap >> 'macrostep-mode-map "2023") >> (define-obsolete-variable-alias 'macrostep-keymap 'macrostep-mode-map "2022") > > The years there should be changed to Emacs versions, I think. > >> (defvar macrostep-mode-map >> (let ((map (make-sparse-keymap))) >> (define-key map (kbd "RET") #'macrostep-expand) >> (define-key map "=" #'macrostep-expand) >> (define-key map "e" #'macrostep-expand) > > Bonus points for converting this into defvar-keymap. > >> ;; Local Variables: >> ;; indent-tabs-mode: nil >> ;; End: > > I think this should be deleted, as this is now the default in ELisp > buffers. OK, I'll start working on these. For the macrostep commits, is it easier for future integration that this is done externally and submitted in one go, or would something like a new macrostep branch in the Emacs tree be more appropriate?