From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: master ac797f60160 2/2: ; * lisp/net/shr.el (shr-image-zoom-levels): Fix wrong type. Date: Wed, 10 Jul 2024 10:46:57 +0000 Message-ID: <87r0c1h6ce.fsf@posteo.net> References: <172054273136.24557.15429439759711990393@vcs2.savannah.gnu.org> <20240709163212.254C9C2BC9A@vcs2.savannah.gnu.org> <877cdua4ur.fsf@gmail.com> <811B0DE0-5514-436F-9D95-8F6294FB4909@gmail.com> <8734ohaa9m.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6285"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , Emacs Devel , Jim Porter To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 10 12:48:13 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRUrt-0001MW-Lm for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Jul 2024 12:48:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRUr1-0001Lk-1l; Wed, 10 Jul 2024 06:47:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRUqv-0001LP-NM for emacs-devel@gnu.org; Wed, 10 Jul 2024 06:47:15 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRUql-0007NF-OL for emacs-devel@gnu.org; Wed, 10 Jul 2024 06:47:13 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id F22AD240101 for ; Wed, 10 Jul 2024 12:46:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1720608419; bh=uNpFheKrEkW+WDBUJnJ0VLtIbdiSrwVvmwIfe+zvxqo=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=C1pXARgvf8NL61Wf1J0pVi9Ho2UpaQ0wzzaUN1wFGVD76OA8rLfH8kNW4FhaU6MPF YAeOcaHHGdIxobHo0nuFAwZ36SjJCh5nP464AsHqr9U1jfGk+u24wydWw4A0UZUJTw P6T/X/T3FQZG0VG/7r+QQHjZkLN4MQn4xlrwDZ/k1YnWIQqvSbgvnRVmqJ++wxFP5l wkU/7tzvLbIQ53AB5fNlmeW38jE9L+Vf+cYasOWVa1DeuQD9BeQh90Gr25HeUxD8sP GG5ZY00sqdu0T+u043/Ck92aLyWD6DVzhrm3KE+EuaiZS6qJX4xcM3BiSS9t0+rd45 XYo9ryhJT/ZtQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WJvgQ0r2Lz6tyL; Wed, 10 Jul 2024 12:46:58 +0200 (CEST) In-Reply-To: <8734ohaa9m.fsf@gmail.com> (Robert Pluim's message of "Wed, 10 Jul 2024 11:04:05 +0200") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321575 Archived-At: Robert Pluim writes: >>>>>> On Wed, 10 Jul 2024 10:46:56 +0200, Mattias Engdeg=C3=A5rd said: > > Mattias> 9 juli 2024 kl. 18.48 skrev Robert Pluim : > >> Wouldn=CA=BCt this look better: > >>=20 > >> :type '(repeat (radio > >> (const :tag "Fit to window size" fit) > >> (const :tag "Original size" original) > >> (const :tag "Full image size" image) > >> (const :tag "Fill window height" fill-height)))) > > Mattias> That's something for the original author (J.P.) to decide; I= just made the type agree with the value. > > The type agrees with the value, but not the documentation: > > Each element > can be one of the following symbols: > > * `fit': Display the image at its original size as requested by the > page, shrinking it to fit in the current window if necessary. > * `original': Display the image at its original size as requested by = the > page. > * `image': Display the image at its full size (ignoring the width/hei= ght > specified by the HTML). > * `fill-height': Display the image zoomed to fill the height of the > current window." > > The current type lets you choose to enable each option, but not to > reorder them without resorting to lisp code. Isn't that solved by adding a :greedy (see (widget) checklist). Arguably this should be enabled by default for `set' types. > Robert --=20 Philip Kaludercic on peregrine