From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Luis Henriques Newsgroups: gmane.emacs.devel Subject: Re: Gnus: fix article to always display git diffs properly Date: Thu, 11 Jul 2024 09:14:25 +0100 Message-ID: <87r0c0mjku.fsf@orpheu.olymp> References: <87v81dmhxi.fsf@orpheu.olymp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15754"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 11 12:05:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRqgJ-0003gA-GQ for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Jul 2024 12:05:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRqfe-0007je-Tm; Thu, 11 Jul 2024 06:05:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRowq-0002Db-2b for emacs-devel@gnu.org; Thu, 11 Jul 2024 04:14:40 -0400 Original-Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1sRowo-0007G2-7Q; Thu, 11 Jul 2024 04:14:39 -0400 Original-Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4WKSF10vYRz9spm; Thu, 11 Jul 2024 10:14:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=camandro.org; s=MBO0001; t=1720685669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kURfDnA/wnf4Dhe+AqHlMFp+d61JISwaA5jaBEMdVQw=; b=xGFlf7ri0jF8/glIWTpgtVWubiMzmKrs1saKWJBcX0n9eAnBcgBDzv89FyoBwV62dH5E+k vWuiw09nJKqWP/JEyXl0BwQmcvjyYpyrMMsVWJJPZTpgYrr2eJ5Hw81eCU2Y8h5G8Vd+fR G1gw3Qu3/2aalR1mQDjKYQkGN0JS5DxzfZ4UqJjYUh0ODb+biy/5Ttg4gAHxsqLzz1+x21 xasS7E58W2BhWV9J6bCUHxFngOOJIDm8kBPwF7au5v+c2OajKONWm+10S25fmBHXQN/VPw 9WC7E5MWrScXK63e/4kEIdooFL1k73woHfCCWEd2EG/G90wYKyWzPKtGOFTzww== In-Reply-To: (Andrea Corallo's message of "Wed, 10 Jul 2024 17:55:51 -0400") X-Rspamd-Queue-Id: 4WKSF10vYRz9spm Received-SPF: pass client-ip=2001:67c:2050:0:465::202; envelope-from=henrix@camandro.org; helo=mout-p-202.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 11 Jul 2024 06:05:00 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321584 Archived-At: Hi Andrea On Wed, Jul 10 2024, Andrea Corallo wrote: > Luis Henriques writes: > >> Hi! >> >> It's been a while since I realised that some emails containing inline >> patches generated with git aren't actually recognised as such in Gnus. >> And today I finally decided to figure out why. Basically, it's because = it >> is assumed that those patches will end with a signature -- and that's not >> always true. >> >> Below there's a one-liner that seems to fix it -- it's not thoroughly te= sted, >> but nothing seems to break. Note that the other diff elements don't have >> an 'end-point' either. Would this change be acceptable? >> >> (And also note that the patch does *not* have a signature at the end!) >> >> Cheers, > > Hi Luis, > > thanks, would you mind sending the patch following [1] so we can discuss > and track it into the bug tracker? Ah! yes, of course. That's exactly what I should have done in the first place. Sorry, I'll do that later today. And thank you for your feedback. Cheers, --=20 Lu=C3=ADs