Re: Accidental change of behaviour for electric-layout-mode?

[Morgan Willcock <morgan@ice9.digital>]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Morgan Willcock <morgan@ice9.digital>
>> Cc: emacs-devel@gnu.org
>> Date: Tue, 24 Sep 2024 19:59:47 +0100
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >> You can revert it (or make it optional), etc.
>> >
>> > Thanks.  So Morgan, please post a patch that makes this feature
>> > opt-in.
>> 
>> Patch is attached.
>
> Thanks, but shouldn't the new variable be a defcustom, i.e. a user
> option?  AFAIU, the preference is on the user level.

I am following the lead of electric-layout-allow-duplicate-newlines
which is not a user option.

For my use case, electric-layout-rules is being set by a major-mode and
the functions in those rules would need to be paired with the ability to
insert a newline within a comment.  If you needed another example of a
major-mode configuring it, python-mode is also setting rules at the mode
level:

https://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/progmodes/python.el?id=dfecd6037d5ebe5778c40ff7b38bfcbaa3ef779e

If there is any doubt about the usage of the new variable I am happy to
just put the original behaviour back and omit the new option for the
moment.

> Also, this needs a NEWS entry.

Does it need a NEWS entry if it is not a user option and the default
behaviour is the same as Emacs 29?

-- 
Morgan Willcock