From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pengji Zhang Newsgroups: gmane.emacs.devel Subject: Re: Comint-like history search for Eshell? Date: Sat, 09 Nov 2024 18:50:28 +0800 Message-ID: <87r07kbs0b.fsf@pengjiz.com> References: <878qu01mfc.fsf@pengjiz.com> <86msi9tp53.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6734"; mail-complaints-to="usenet@ciao.gmane.io" To: James Thomas , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 09 13:36:17 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t9khK-0001ZW-3l for ged-emacs-devel@m.gmane-mx.org; Sat, 09 Nov 2024 13:36:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9kTL-0004z8-RQ; Sat, 09 Nov 2024 07:21:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9j39-0007FB-U0 for emacs-devel@gnu.org; Sat, 09 Nov 2024 05:50:40 -0500 Original-Received: from fout-b7-smtp.messagingengine.com ([202.12.124.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9j38-0003RH-H3 for emacs-devel@gnu.org; Sat, 09 Nov 2024 05:50:39 -0500 Original-Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id C7AC111400E5; Sat, 9 Nov 2024 05:50:37 -0500 (EST) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Sat, 09 Nov 2024 05:50:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pengjiz.com; h= cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1731149437; x=1731235837; bh=YApzxWN/vo 6daSryKeJmrsgQWQcenffVnMCU9sr8g7c=; b=GlMuVsnhMySSZb3f99zhTlQKD8 a63NrPbw6rJLJfEjtsskrCZCe/li4JBR+Ji/EdTD/R3TZYCJ37DZYVR9CqkvwJDY I9Y/sgnysHFxzhrLrlmHgLAGMCimwsGdEflDNb9npqxPajp/bNKPNFY+Y9Lq6vlH K6D3qz+TCEgxBjMl+laUB/ja0fBdssYHonCDjFdPDWNu2fu3rtb99GHaRGCYyt27 feJB8IWUGMmndyzMbvYwkq5p5ZFpVc2vIsur8D/W52WnQW9Vi1WeB83LaLwBtPEi +vrhS688NoEdppkMBSt6f+8axr9Z4RwCGdA0radcxadxqExJTQQ0e4Xf/hlg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1731149437; x=1731235837; bh=YApzxWN/vo6daSryKeJmrsgQWQcenffVnMC U9sr8g7c=; b=GCdWGeGUvt8TZ1rubXcFn2L3opwSE6wiaFuuVNTRrvwLP7RdULo yZPujKjUZiIH7jl4JJbmQgenczDEt1ticQH9qG0o6ZkwNJrvgNr1qBbhkY6TeZBC WY2ppvuUrvDP0aCItFBgo4vTvRIOVcHcB7SLsyV0u/K0AikifmfaPlS1H3jeWpFQ 1GMilk4wQDIL2JKwzyUBrxtbYdhIP8MrtoMSWo9LF+cOg9dIgKeDlhRUp7jdnYbv IvjzYmIRzAgf1+QEpwqXeW0bklG9YvDG7gz+vh6+8Dbjd8FdLWLZmlntVrGzwnbn qrZA20Sbd81VTaNdH5A3ukpkom5wrhP+jOw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtdekgddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfh ffkfggtgesthdtredttddttdenucfhrhhomheprfgvnhhgjhhiucgkhhgrnhhguceomhgv sehpvghnghhjihiirdgtohhmqeenucggtffrrghtthgvrhhnpeeivdekhfekieetfefgue evkeduteevveeggffhleekveehtdegveeggfduhedvgfenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmvgesphgvnhhgjhhiiidrtghomhdpnh gspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepjhhimhhj ohgvsehgmhigrdhnvghtpdhrtghpthhtohepvghmrggtshdquggvvhgvlhesghhnuhdroh hrgh X-ME-Proxy: Feedback-ID: i16614472:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 9 Nov 2024 05:50:36 -0500 (EST) In-Reply-To: <86msi9tp53.fsf@gmx.net> Received-SPF: pass client-ip=202.12.124.150; envelope-from=me@pengjiz.com; helo=fout-b7-smtp.messagingengine.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 09 Nov 2024 07:20:02 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325330 Archived-At: James Thomas writes: > (Posting here as there seems to be no bug report as yet) I am working on a new patch, and I will file a bug report later. > A small thing: With your patch, if you cancel after an M-r search > (with C-g) then the position in the history ring is left at the > command that was displayed, and not to the one at the start. Is this > intentional? No, it is not. Thanks for reporting this! I have located the cause of it, and I will fix it in the new patch. Pengji