From: Lute Kamstra <Lute.Kamstra.lists@xs4all.nl>
Cc: emacs-devel@gnu.org
Subject: Re: battery.el: Rename display-battery-mode to battery-mode?
Date: Thu, 04 Aug 2005 08:57:08 +0200 [thread overview]
Message-ID: <87pssu42bf.fsf@xs4all.nl> (raw)
In-Reply-To: <v9u0i8gvsg.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Tue, 02 Aug 2005 18:15:11 +0200")
Reiner Steib <reinersteib+gmane@imap.cc> writes:
> I tried to enable battery-mode on my notebook using `M-x battery- TAB'
> but I got "No match". Eventually I found `display-battery-mode' in
> `battery.el'. Shouldn't the name of the minor mode read
> `battery-mode' instead of `display-battery-mode'?
Agreed.
> --8<---------------cut here---------------start------------->8---
> --- battery.el 17 Jul 2005 19:58:18 +0200 1.28
> +++ battery.el 02 Aug 2005 17:59:51 +0200
> @@ -131,7 +131,7 @@
> "Battery status not available")))
>
> ;;;###autoload
> -(define-minor-mode display-battery-mode
> +(define-minor-mode battery-mode
> "Display battery status information in the mode line.
> The text being displayed in the mode line is controlled by the variables
> `battery-mode-line-format' and `battery-status-function'.
> @@ -149,6 +149,8 @@
> 'battery-update-handler))
> (battery-update)))
>
> +(define-obsolete-function-alias 'display-battery-mode 'battery-mode "22.1")
> +
> (defun battery-update-handler ()
> (battery-update)
> (sit-for 0))
> --8<---------------cut here---------------end--------------->8---
>
> Okay to commit?
Ok with me.
> Shouldn't battery mode be mentioned briefly in (info "(emacs)Optional
> Mode Line") as well?
Maybe you can write a patch?
Lute.
next prev parent reply other threads:[~2005-08-04 6:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-02 16:15 battery.el: Rename display-battery-mode to battery-mode? Reiner Steib
2005-08-04 6:57 ` Lute Kamstra [this message]
2005-08-04 15:54 ` Reiner Steib
2005-08-04 16:28 ` Juri Linkov
2005-08-06 1:06 ` Juri Linkov
2005-08-06 18:36 ` Richard M. Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pssu42bf.fsf@xs4all.nl \
--to=lute.kamstra.lists@xs4all.nl \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).