From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: hi-lock mode and special buffers Date: Thu, 24 Nov 2005 11:05:53 -0500 Message-ID: <87psoqav4u.fsf@stupidchicken.com> References: <87ek563ytf.fsf@pacem.orebokech.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1132853346 6163 80.91.229.2 (24 Nov 2005 17:29:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 24 Nov 2005 17:29:06 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 24 18:29:05 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EfKrX-0005XZ-6c for ged-emacs-devel@m.gmane.org; Thu, 24 Nov 2005 18:26:23 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EfKrW-0006zq-Gl for ged-emacs-devel@m.gmane.org; Thu, 24 Nov 2005 12:26:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EfJbf-0002Kt-Qs for emacs-devel@gnu.org; Thu, 24 Nov 2005 11:05:57 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EfJbb-0002IZ-P4 for emacs-devel@gnu.org; Thu, 24 Nov 2005 11:05:53 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EfJbZ-0002I0-MW for emacs-devel@gnu.org; Thu, 24 Nov 2005 11:05:50 -0500 Original-Received: from [18.95.5.42] (helo=localhost.localdomain) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EfJbZ-0001QT-KF for emacs-devel@gnu.org; Thu, 24 Nov 2005 11:05:49 -0500 Original-Received: by localhost.localdomain (Postfix, from userid 1000) id 40E311E41FE; Thu, 24 Nov 2005 11:05:53 -0500 (EST) Original-To: Romain Francoise In-Reply-To: <87ek563ytf.fsf@pacem.orebokech.com> (Romain Francoise's message of "Thu, 24 Nov 2005 15:28:12 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:46520 Archived-At: Romain Francoise writes: > This change: > > 2005-11-12 Chong Yidong > > * hi-lock.el (hi-lock-mode): Set the default value of > font-lock-defaults. > > breaks fontification in special buffers if hi-lock mode is enabled. > This affects Gnus and ERC, among others; see Bill's report about Gnus > (<9993.1131326507@olgas.newt.com>) and the following Debian bug: > > > > What was this change supposed to fix? Is there a better way? The bug is "No highlight in compilation-minor-mode when hi-lock-mode is on", at http://lists.gnu.org/archive/html/emacs-pretest-bug/2005-11/msg00173.html The old behavior of hi-lock mode is that it sets the font-lock-defaults to '(nil) when it is turned on. However, font-lock-defaults is buffer-local, so the value for other buffers is unchanged, even though hi-lock-mode applies to them as well. That was the source of the incompatibility with compilation-minor-mode.