From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Rewrite of vc-user-login-name Date: Sun, 22 Jan 2006 23:22:04 +0100 Message-ID: <87psmjx5rn.fsf@gmx.de> References: <1137946789.5032.149.camel@localhost> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1137990567 9861 80.91.229.2 (23 Jan 2006 04:29:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 23 Jan 2006 04:29:27 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 23 05:29:24 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F0tKT-0007RT-DQ for ged-emacs-devel@m.gmane.org; Mon, 23 Jan 2006 05:29:21 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F0tN5-0002YC-T9 for ged-emacs-devel@m.gmane.org; Sun, 22 Jan 2006 23:32:03 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F0ndm-0008SI-Nf for emacs-devel@gnu.org; Sun, 22 Jan 2006 17:24:55 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F0ndk-0008QK-2w for emacs-devel@gnu.org; Sun, 22 Jan 2006 17:24:53 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F0ndj-0008PE-On for emacs-devel@gnu.org; Sun, 22 Jan 2006 17:24:51 -0500 Original-Received: from [213.165.64.21] (helo=mail.gmx.net) by monty-python.gnu.org with smtp (Exim 4.34) id 1F0niM-0000Ec-0k for emacs-devel@gnu.org; Sun, 22 Jan 2006 17:29:38 -0500 Original-Received: (qmail invoked by alias); 22 Jan 2006 22:22:05 -0000 Original-Received: from p54BD91CC.dip0.t-ipconnect.de (EHLO localhost.local) [84.189.145.204] by mail.gmx.net (mp031) with SMTP; 22 Jan 2006 23:22:05 +0100 X-Authenticated: #3708877 Original-To: Andre Spiegel In-Reply-To: <1137946789.5032.149.camel@localhost> (Andre Spiegel's message of "Sun, 22 Jan 2006 17:19:48 +0100") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-Mailman-Approved-At: Sun, 22 Jan 2006 23:31:34 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49433 Archived-At: Andre Spiegel writes: > Here's a patch that closes a long standing issue, removing the need for > Tramp to advise vc-user-login-name. I'm not quite sure how to install > it, though: should I just remove the advice in tramp-vc.el? Is that > guaranteed not to break anything if people simply update from CVS? > (Since the argument list changed, the tramp advice no longer works with > this patch.) I'll check the needed changes in tramp-vc.el next days. A simple remove of the defadvice is not desirable, because Tramp is intended to work with older Emacsen too. Unfortunately, your patch came too late for the just released Tramp 2.0.52. But so what ... Best regards, Michael.