unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kevin Ryde <user42@zip.com.au>
Subject: Re: fix the sscanf usage in etags
Date: Wed, 09 Aug 2006 10:06:24 +1000	[thread overview]
Message-ID: <87psfa93i7.fsf@zip.com.au> (raw)
In-Reply-To: <20060807.123850.192456906.jet@gyve.org> (Masatake YAMATO's message of "Mon, 07 Aug 2006 12:38:50 +0900 (JST)")

Masatake YAMATO <jet@gyve.org> writes:
>
> -	  if (sscanf (lbp->buffer, "#line %d \"%n", &lno, &start) == 1)
> +	  if (sscanf (lbp->buffer, "#line %d \"%n", &lno, &start) == 2)

I think that's wrong, I believe %n is not included in the return
count.  Eg. in the current glibc, and in the posix spec (under "n"),

    http://www.opengroup.org/onlinepubs/007904975/functions/scanf.html

It does look like there's a problem with degenerate input having
"start" used uninitialized though.  Eg. say

	#line 00000000000000000000000000000

  parent reply	other threads:[~2006-08-09  0:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-07  3:38 fix the sscanf usage in etags Masatake YAMATO
2006-08-08  9:35 ` Jan Djärv
2006-08-09  0:06 ` Kevin Ryde [this message]
2006-08-09  6:57   ` Jan Djärv
2006-08-09  7:57     ` Masatake YAMATO
2006-08-09 13:20       ` Jan Djärv
2006-08-09 14:10         ` Masatake YAMATO
2006-08-10  0:15     ` Kevin Ryde
2006-08-10  6:47       ` Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87psfa93i7.fsf@zip.com.au \
    --to=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).