Re: keypad-*-setup

[storm@cua.dk (Kim F. Storm)]

"Drew Adams" <drew.adams@oracle.com> writes:

>> > 1. A nil ("No change (keep existing bindings)") value for the
>> > setup options seems to be a no-op.... Am I reading this wrong?
>>
>> I don't really remember why I included that choice.
>> Most likely it was a way to specify "use default bindings or whatever
>> the user has changed them to".
>
> Do you agree that it is a no-op, and can be removed (or am I missing
> something)?

What if user has once customized one of the keypad setups, and later
wants to revert to the "default setting" ... then there need to be a
setting which corresponds to that setting.  

So I don't think it is a no-op.  But this may be one of the things I
don't understand about Customize :-)

> OK. Then I suggest that we remove the `numeric' choice. Even if someone did
> implement what you suggest someday, that could be done by providing the
> "right" default value for the explicit decimal-point character (which the
> user could choose to override or not). Do you agree?

What about users who already has set keypad binding to numeric ?

> Perhaps whoever is finalizing this patch for CVS etc. can try that. I think
> it should be correct.

I think everybody expected you to finalize the patch :-)

But if you make another revision of the patch, I'll take a look at
finalizing it.

> The difficulty I saw was that the previous manual section, Function Keys,
> speaks of keys such as <kp-divide> as "keypad" keys, but keypad.el is not
> concerned with those. There are two different uses of the word "keypad" in
> the manual, one refers to all keys with prefix `kp-'; the other refers only
> to the 11 numeric keys 0-9 and `.'.

Those extra keys are not affected by the state of the numlock key.

That's also why I prefer to say "numeric keypad" rather than keypad.
Perhaps the package should have been called numlock.el, numpad.el or
some such.  But I guess that's too late now.

> There needs, I think, to be some explanation of the terminology to avoid
> confusion - the reader of the previous manual section will otherwise
> misunderstand what is said in this section. Feel free to propose something
> shorter to make this point.

I think you made a good attempt at explaining it - saying that it
applies only to 0..9 and decimal/del key.  To remove the possible
confusion one could just say: 

"The other keypad keys (such as kp-divide) are not affected by the
keypad customizations described here".

>> The Shift key and the NumLock key modify the behavior of keys on the
>> numeric keypad.  The Shift key acts as usual.  The NumLock key toggles
>> the keypad keys between two possible modes: numeric and non-numeric.
>
> Sounds good to me.

Ok.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk