From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: doc-view warnings Date: Fri, 16 Nov 2007 18:04:21 +0100 Message-ID: <87prya9l62.fsf@baldur.tsdh.de> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1195233069 21351 80.91.229.12 (16 Nov 2007 17:11:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 Nov 2007 17:11:09 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 16 18:11:03 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1It4iM-0005wG-GL for ged-emacs-devel@m.gmane.org; Fri, 16 Nov 2007 18:10:46 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1It4i9-0000Sk-9n for ged-emacs-devel@m.gmane.org; Fri, 16 Nov 2007 12:10:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1It4cF-0008Dm-4F for emacs-devel@gnu.org; Fri, 16 Nov 2007 12:04:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1It4cD-0008AQ-AC for emacs-devel@gnu.org; Fri, 16 Nov 2007 12:04:26 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1It4cD-0008AE-3J for emacs-devel@gnu.org; Fri, 16 Nov 2007 12:04:25 -0500 Original-Received: from out1.smtp.messagingengine.com ([66.111.4.25]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1It4cC-0003b9-IO for emacs-devel@gnu.org; Fri, 16 Nov 2007 12:04:24 -0500 Original-Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id 3C88E41805 for ; Fri, 16 Nov 2007 12:04:24 -0500 (EST) Original-Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 16 Nov 2007 12:04:24 -0500 X-Sasl-enc: 3TBY76Tdso1GUxAIQP1khsPWSwELcf8QHk/2I2Pzhzay 1195232663 Original-Received: from baldur.tsdh.de (dslb-084-063-069-135.pools.arcor-ip.net [84.63.69.135]) by mail.messagingengine.com (Postfix) with ESMTP id 6FF6E2A68A for ; Fri, 16 Nov 2007 12:04:23 -0500 (EST) Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: (Dan Nicolaescu's message of "Fri, 16 Nov 2007 08:52:27 -0800") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83354 Archived-At: Dan Nicolaescu writes: Hi Dan! > These might be bugs: > > In doc-view-search-backward: > doc-view.el:790:20:Warning: reference to free variable `arg' > > In doc-view-search: > doc-view.el:798:17:Warning: reference to free variable `arg' Oh, yes, they are. Here's the fix: --8<---------------cut here---------------start------------->8--- 2007-11-16 Tassilo Horn * doc-view.el (doc-view-search-backward, doc-view-search): Fix assignment to free variable bug. --8<---------------cut here---------------end--------------->8--- --8<---------------cut here---------------start------------->8--- Index: lisp/doc-view.el =================================================================== RCS file: /sources/emacs/emacs/lisp/doc-view.el,v retrieving revision 1.22 diff -u -r1.22 doc-view.el --- lisp/doc-view.el 16 Nov 2007 16:50:35 -0000 1.22 +++ lisp/doc-view.el 16 Nov 2007 17:04:02 -0000 @@ -787,7 +787,7 @@ "Call `doc-view-search' for backward search. If prefix NEW-QUERY is given, ask for a new regexp." (interactive "P") - (doc-view-search arg t)) + (doc-view-search new-query t)) (defun doc-view-search (new-query &optional backward) "Jump to the next match or initiate a new search if NEW-QUERY is given. @@ -795,7 +795,7 @@ till now do that first. If BACKWARD is non-nil, jump to the previous match." (interactive "P") - (if (and (not arg) + (if (and (not new-query) doc-view-current-search-matches) (if backward (doc-view-search-previous-match 1) --8<---------------cut here---------------end--------------->8--- Bye, Tassilo