From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: doc-view support for bookmark.el Date: Tue, 25 Dec 2007 15:42:07 +0100 Message-ID: <87prwu3kg0.fsf@member.fsf.org> References: <8763yn3v07.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1198594105 28433 80.91.229.12 (25 Dec 2007 14:48:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Dec 2007 14:48:25 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 25 15:48:38 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from mail-forward.uio.no ([129.240.10.42]) by lo.gmane.org with esmtp (Exim 4.50) id 1J7B4x-0006OQ-Rn for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 15:48:23 +0100 Original-Received: from mail-mx4.uio.no ([129.240.10.45]) by pat.uio.no with esmtp (Exim 4.67) (envelope-from ) id 1J7B4d-0005AV-Oo for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 15:48:03 +0100 Original-Received: from lists.gnu.org ([199.232.76.165]) by mail-mx4.uio.no with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1J7B4Q-0003P6-EE for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 15:48:03 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7Az6-00022P-35 for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 09:42:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J7Az1-00021r-Ru for emacs-devel@gnu.org; Tue, 25 Dec 2007 09:42:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J7Ayw-000216-Mx for emacs-devel@gnu.org; Tue, 25 Dec 2007 09:42:14 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7Ayw-000213-H1 for emacs-devel@gnu.org; Tue, 25 Dec 2007 09:42:10 -0500 Original-Received: from out4.smtp.messagingengine.com ([66.111.4.28]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J7Ayw-0002ET-8U for emacs-devel@gnu.org; Tue, 25 Dec 2007 09:42:10 -0500 Original-Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id F1F818266A for ; Tue, 25 Dec 2007 09:42:09 -0500 (EST) Original-Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 25 Dec 2007 09:42:09 -0500 X-Sasl-enc: IsHt+wPZk+8BEBcdCG7G+vT1pU2a60sK4Q1N6PAvAfhU 1198593729 Original-Received: from baldur (dslb-084-063-018-200.pools.arcor-ip.net [84.63.18.200]) by mail.messagingengine.com (Postfix) with ESMTP id 3E2F92B457 for ; Tue, 25 Dec 2007 09:42:08 -0500 (EST) Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: (Stefan Monnier's message of "Tue, 25 Dec 2007 06:43:18 -0500") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-UiO-SPF-Received: Received-SPF: pass (mail-mx4.uio.no: domain of gnu.org designates 199.232.76.165 as permitted sender) client-ip=199.232.76.165; envelope-from=emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org; helo=lists.gnu.org; X-UiO-ClamAV-Virus: No X-UiO-Spam-info: not spam, SpamAssassin (score=-0.3, required=5.0, autolearn=disabled, AWL=0.712,RCVD_IN_DNSWL_LOW=-1) X-UiO-Scanned: EC3E2DC3834BBB38658A36D4CBE06656AC54049D X-UiO-SPAM-Test: remote_host: 199.232.76.165 spam_score: -2 maxlevel 200 minaction 2 bait 0 mail/h: 2 total 30343 max/h 424 blacklist 0 greylist 0 ratelimit 0 Xref: news.gmane.org gmane.emacs.devel:85445 Archived-At: Stefan Monnier writes: Hi Stefan, >> on emacs-sources there was a request for a bookmarking facility for >> doc-view, so I added support for it in bookmark.el. > > Could we try and find a way to make the two packages independent: > bookmark.el should provide a way for doc-view.el to override the > behavior of bookmark commands in doc-view buffers. Sure, a general interface would be a good idea. Do you propose an one? A simple approach could be to add 2 new variables - bookmark-make-cell-function: A function that creates the record part of the bookmark (default: the current bookmark-make-cell after renaming it appropriately) - bookmark-jump-function: A function that jumps to the given bookmark location without selecting it. (default: the current bookmark-jump-noselect) What do you think? And what about the other changes? (Return value of bookmark-jump-noselect and the adaption of its callers.) If it's ok I'll check it in now and omit the doc-view stuff till we agree on general interface. Bye, Tassilo