From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el and lisp/gnus/gnus-bookmark.el Date: Sat, 08 Mar 2008 20:47:42 +0000 Message-ID: <87pru5gcy9.fsf@bzg.ath.cx> References: <874pbj682f.fsf@red-bean.com> <87zltbhbq8.fsf@bzg.ath.cx> <87iqzzigv6.fsf@bzg.ath.cx> <87ejan7xhq.fsf@member.fsf.org> <87hcfi3egg.fsf@bzg.ath.cx> <87abla8w6b.fsf@member.fsf.org> <87bq5qhba6.fsf@bzg.ath.cx> <871w6m8t59.fsf@member.fsf.org> <87ablamphg.fsf@red-bean.com> <87skz2lacp.fsf@bzg.ath.cx> <87tzjil9oz.fsf@red-bean.com> <8763vyl964.fsf@bzg.ath.cx> <874pbiypad.fsf@bzg.ath.cx> <87ejalv8an.fsf@bzg.ath.cx> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1205009287 23427 80.91.229.12 (8 Mar 2008 20:48:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Mar 2008 20:48:07 +0000 (UTC) Cc: Karl Fogel , Tassilo Horn , Reiner Steib , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 08 21:48:34 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JY5xz-0000E6-KT for ged-emacs-devel@m.gmane.org; Sat, 08 Mar 2008 21:48:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JY5xR-0007fX-QV for ged-emacs-devel@m.gmane.org; Sat, 08 Mar 2008 15:47:53 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JY5xM-0007dQ-F9 for emacs-devel@gnu.org; Sat, 08 Mar 2008 15:47:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JY5xL-0007cS-Ez for emacs-devel@gnu.org; Sat, 08 Mar 2008 15:47:47 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JY5xL-0007cL-AA for emacs-devel@gnu.org; Sat, 08 Mar 2008 15:47:47 -0500 Original-Received: from fg-out-1718.google.com ([72.14.220.159]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JY5xK-0002H8-IH for emacs-devel@gnu.org; Sat, 08 Mar 2008 15:47:47 -0500 Original-Received: by fg-out-1718.google.com with SMTP id d23so1217937fga.30 for ; Sat, 08 Mar 2008 12:47:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:received:from:to:cc:subject:in-reply-to:references:user-agent:date:message-id:mime-version:content-type:sender; bh=4A3nbKMeNPNWLi3WWBkWm9d06iCW0y0tpIbNDX7ACCU=; b=JlH+SUVSTkTnplK36Mt13xwmoNDQMqSFjn0n0BLBfoWMKXqwzVnLRkwqtBFYSqQIpOTiYz/g/UCaF5yB610buM4KxkP9ymhRdzVX2eWlQ2kB61LpXt+FqCrQiQYSE75PQcL2Oe+8q7USfPuhRABcr0giYk9UhJ8Yrk3IKKoggOA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date:message-id:mime-version:content-type:sender; b=MK7UUhQtc5LbscYcUs8pFb+ZRESmRi7GeZsUtJEYb2tpUxtVvexOnH1z2T3uq+BRUOfAs5S/dFfrbqETkvCcv9Ticq38uGCYNqFtg+gsOcEsjMAKoMjfBopx+pXPJDA2Zk+bXbA+6Wvh90YWjlciNe0r9KbRz4gAK8+KmN0sXaQ= Original-Received: by 10.82.166.9 with SMTP id o9mr7408945bue.33.1205009265033; Sat, 08 Mar 2008 12:47:45 -0800 (PST) Original-Received: from bzg.ath.cx ( [81.99.213.34]) by mx.google.com with ESMTPS id m5sm6140439gve.11.2008.03.08.12.47.42 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 08 Mar 2008 12:47:43 -0800 (PST) Original-Received: by bzg.ath.cx (Postfix, from userid 1000) id C27AA15796E; Sat, 8 Mar 2008 20:47:42 +0000 (GMT) In-Reply-To: (Stefan Monnier's message of "Sat, 08 Mar 2008 14:54:17 -0500") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91772 Archived-At: Stefan Monnier writes: >> If we get rid of the annotation argument for this single function, it >> means the annotation has to be done before this function returns sth >> that can be used as the suggested name for the bookmark. > > AFAICT getting rid of the annotation argument means nothing at all, > other than that the annotation will have to be added by the generic > bookmark-set code rather than being done by every single > bookmark-make-record-function. For now `bookmark-set' asks for an annotation (if required), sends it to `bookmark-make' which calls `bookmark-make-record-function' with the annotation as an argument. IIUC Tassilo suggested that the annotation should be directly handled by `bookmark-make-record-function', which seems correct to me. What you propose is to handle annotation in `bookmark-set' (or preferrably in `bookmark-make') -- this is _feasible_, but it looks weird to me since the annotation is really part of the record. BTW, I really think the name suggestion should be taken care of by `bookmark-make-record-function' (with an optional "name" arg), not by a separate call to `bookmark-make-name-function'... Anyway - I let Karl summary and decide on this! -- Bastien