From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50; Middle w in of permissions in dired-mode is red and bold: dired-warning Date: Thu, 13 Mar 2008 12:37:10 +0200 Organization: JURTA Message-ID: <87prtyx63t.fsf@jurta.org> References: <87hckt9z1u.fsf_-_@jurta.org> <878x0n1g86.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1205405031 9926 80.91.229.12 (13 Mar 2008 10:43:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Mar 2008 10:43:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 13 11:44:19 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JZkv3-0004Ul-Pb for ged-emacs-devel@m.gmane.org; Thu, 13 Mar 2008 11:44:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JZks9-00079C-82 for ged-emacs-devel@m.gmane.org; Thu, 13 Mar 2008 06:41:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JZkrY-000715-0G for emacs-devel@gnu.org; Thu, 13 Mar 2008 06:40:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JZkrW-00070k-CY for emacs-devel@gnu.org; Thu, 13 Mar 2008 06:40:39 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JZkrW-00070f-2r for emacs-devel@gnu.org; Thu, 13 Mar 2008 06:40:38 -0400 Original-Received: from relay03.kiev.sovam.com ([62.64.120.201]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JZkrR-0005k8-P5; Thu, 13 Mar 2008 06:40:34 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay03.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1JZkrI-0008XS-Rk; Thu, 13 Mar 2008 12:40:31 +0200 In-Reply-To: (Eli Zaretskii's message of "Thu, 13 Mar 2008 06:21:42 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-unknown-linux-gnu) X-Scanner-Signature: 4204c266f86c3e9b1e0231505dd73b85 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2396 [Mar 12 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 11 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 6.x (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:92392 Archived-At: >> When testing Emacs 22 with `emacs -Q', I see that dired buffers are >> almost unusable by default. The red bold face for write permissions >> is very distracting that prevents focusing on other parts of the dired >> buffer. I'm afraid Emacs users will hate us for this if we release >> Emacs 22.2 with this annoyance. >> >> I propose a patch below for the 22 branch that renames the face >> `dired-warn-writable' to more appropriate name `dired-perm-write' >> that doesn't associate it with a warning, and changes its parent face >> from `font-lock-warning-face' to `font-lock-comment-delimiter-face' >> on non-Windows platforms. > > I object. I think now is not the time for making behavioral changes > in the release branch. We are too close to the release. This is not a behavioral change. This is a fix for the grave usability bug you introduced to GNU/Linux users. It seems you realize the severity of this problem since you wrote several times proposing to fix it: > Date: Sun, 14 Oct 2007 06:10:33 +0200 > From: Eli Zaretskii > Then perhaps the new face dired-warn-writable that I introduced > yesterday should inherit from `default' on _all_ platforms, not only > on DOS/Windows. and > Date: Mon, 15 Oct 2007 00:20:45 +0200 > From: Eli Zaretskii > It does fix that on platforms where group- and world-writable files > are the default. On other platforms, you can customize it, or we can > make it inherit from `default' on _all_ platforms. I think it is not yet too late to fix this bug because there is absolutely no risk of breaking something else with this simple fix. -- Juri Linkov http://www.jurta.org/emacs/