From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Fix info display of images Date: Sun, 13 Dec 2009 20:31:35 +0200 Organization: JURTA Message-ID: <87pr6iskww.fsf@mail.jurta.org> References: <874oo5nfsl.fsf@lola.goethe.zz> <87ljhey8gx.fsf@mail.jurta.org> <874oo2jzq2.fsf@lola.goethe.zz> <87aaxnjfkg.fsf@lola.goethe.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1260735622 10342 80.91.229.12 (13 Dec 2009 20:20:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Dec 2009 20:20:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 13 21:20:15 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NJuvO-0000nc-HZ for ged-emacs-devel@m.gmane.org; Sun, 13 Dec 2009 21:20:14 +0100 Original-Received: from localhost ([127.0.0.1]:57328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NJuvO-00016w-E3 for ged-emacs-devel@m.gmane.org; Sun, 13 Dec 2009 15:20:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NJuvJ-00016f-Cm for emacs-devel@gnu.org; Sun, 13 Dec 2009 15:20:09 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NJuvF-00015m-Ni for emacs-devel@gnu.org; Sun, 13 Dec 2009 15:20:09 -0500 Original-Received: from [199.232.76.173] (port=60700 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NJuvF-00015e-GR for emacs-devel@gnu.org; Sun, 13 Dec 2009 15:20:05 -0500 Original-Received: from smtp-out3.starman.ee ([85.253.0.5]:54885 helo=mx1.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NJuvD-00058r-7J; Sun, 13 Dec 2009 15:20:03 -0500 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Original-Received: from mail.starman.ee (62.65.211.90.cable.starman.ee [62.65.211.90]) by mx1.starman.ee (Postfix) with ESMTP id 0554A3F412F; Sun, 13 Dec 2009 22:19:55 +0200 (EET) In-Reply-To: <87aaxnjfkg.fsf@lola.goethe.zz> (David Kastrup's message of "Sun, 13 Dec 2009 12:09:35 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.90 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118593 Archived-At: > Since there does not appear to be interest to apply this patch, let me > illustrate the difference using two screen shots, the first without the > patch, the second with the patch. Thanks, it's clear now what is the reason of this bug. `Info-hide-cookies-node' hides a cookie, including one optional *trailing newline*. The image cookies in Lilypond's Cheat sheet end with trailing newlines, so when `Info-hide-cookies-node' hides the newline, images are displayed in one long line. It seems hiding the newline was necessary only for index cookies, that after hiding would leave an empty line. OTOH, the docstring of `Info-hide-cookies-node' says: Hide unrecognized cookies in current node. So your patch uses `(not (get-text-property start 'display))' to tell `Info-hide-cookies-node' that this cookie was already recognized and processed by `Info-display-images-node'. > I think that the improvement is rather obvious. This is not just improvement, but a plain bug fix. I suggest to install it. Since IIUC currently CVS is read-only, you could create a bug report in the bug database to guarantee your bug fix is not lost and fixed in the next release. -- Juri Linkov http://www.jurta.org/emacs/