From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: pointless buttons at end of VC log buffers Date: Tue, 16 Feb 2010 06:38:40 +0100 Message-ID: <87pr45zqn3.fsf@telefonica.net> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1266298759 19151 80.91.229.12 (16 Feb 2010 05:39:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Feb 2010 05:39:19 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 16 06:39:17 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NhG9U-0000GE-UJ for ged-emacs-devel@m.gmane.org; Tue, 16 Feb 2010 06:39:17 +0100 Original-Received: from localhost ([127.0.0.1]:55787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhG9U-00035v-CR for ged-emacs-devel@m.gmane.org; Tue, 16 Feb 2010 00:39:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NhG9O-00035q-FF for emacs-devel@gnu.org; Tue, 16 Feb 2010 00:39:10 -0500 Original-Received: from [140.186.70.92] (port=37239 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhG9M-00035h-7T for emacs-devel@gnu.org; Tue, 16 Feb 2010 00:39:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NhG9L-0007VI-Li for emacs-devel@gnu.org; Tue, 16 Feb 2010 00:39:08 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:35881) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NhG9L-0007V9-FK for emacs-devel@gnu.org; Tue, 16 Feb 2010 00:39:07 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NhG9I-00008Q-EV for emacs-devel@gnu.org; Tue, 16 Feb 2010 06:39:04 +0100 Original-Received: from 206.red-81-33-105.dynamicip.rima-tde.net ([81.33.105.206]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 16 Feb 2010 06:39:04 +0100 Original-Received: from ofv by 206.red-81-33-105.dynamicip.rima-tde.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 16 Feb 2010 06:39:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 31 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 206.red-81-33-105.dynamicip.rima-tde.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (gnu/linux) Cancel-Lock: sha1:uJfCz5aAbfkSdf+Xnh+l8gabaDI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121138 Archived-At: Miles Bader writes: > If I do a vc log command (e.g., "C-x v L"), i get the log in a > "*vc-change-log*" buffer, and at the veryyy end of the buffer, I see: > > [Show 2X entries] [Show unlimited entries] > > However these buttons seem useless, as the buffer already contains all > log entries (about 1200)! > > * It seems like it should only show these buttons if the log listing > gets interrupted for some reason. For this, VC-log needs to count how many revisions it is showing and compare with the number of revisions on the branch. Looks like too much work. OTOH, on some backends (i.e. git) it is difficult to differentiate the first (oldest) revision from any other on the log listing, as it lacks revision numbers. > Also, the formatting is a bit off, as the above buttons are not preceded > by a newline... they're glommed onto end of the last line of the log > listing. > > * So, some code should make sure there's a newline before the buttons -- > indeed, it should probably add an entire blank line between the last > log line and the buttons so they stand out more (I didn't even notice > them for a while...). It seems that git does not append a newline to the last revision. The buttons look fine for Subversion and Bazaar, although a blank line before them would be aesthetically pleasant.