From: Miles Bader <miles@gnu.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: Julien Danjou <julien@danjou.info>, emacs-devel@gnu.org
Subject: Re: [PATCH 1/2] image: add support for GIF transparency
Date: Fri, 05 Nov 2010 08:01:00 +0900 [thread overview]
Message-ID: <87pquk7kyb.fsf@catnip.gol.com> (raw)
In-Reply-To: <wlhbfxuakb.wl%mituharu@math.s.chiba-u.ac.jp> (YAMAMOTO Mitsuharu's message of "Thu, 04 Nov 2010 10:44:36 +0900")
YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
>> + if (transparent_p && transparency_color_index == i)
>> + pixel_colors[i] = FRAME_BACKGROUND_PIXEL (f);
>
> If we don't have multiple transparency levels in GIF (unlike PNG or
> SVG), then we can construct a clipping mask as we currently do in XPM,
> and that would give us a better result.
A clipping mask might be a better solution even for PNG etc -- it will
have exactly the same appearance on the default background, and will at
least give a better approximation on non-default backgrounds...
-Miles
--
97% of everything is grunge
next prev parent reply other threads:[~2010-11-04 23:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 14:27 [PATCH 1/2] image: add support for GIF transparency Julien Danjou
2010-10-27 14:27 ` [PATCH 2/2] image: add support for specified :background on GIF Julien Danjou
2010-10-27 14:57 ` [PATCH 1/2] image: add support for GIF transparency Julien Danjou
2010-10-27 15:00 ` Julien Danjou
2010-11-03 20:09 ` Chong Yidong
2010-11-04 1:44 ` YAMAMOTO Mitsuharu
2010-11-04 23:01 ` Miles Bader [this message]
2010-10-27 15:00 ` [PATCH 2/2] image: add support for specified :background on GIF Julien Danjou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pquk7kyb.fsf@catnip.gol.com \
--to=miles@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=julien@danjou.info \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).