From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Using the ImageMagick backend seems to leak memory Date: Wed, 12 Jan 2011 08:37:01 +0100 Message-ID: <87pqs2r2si.fsf@member.fsf.org> References: <87sjx6zczl.fsf@member.fsf.org> <30611405.post@talk.nabble.com> <874o9l86eb.fsf@member.fsf.org> <87zkr7nxo8.fsf@member.fsf.org> <8739oz8dei.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1294817838 27830 80.91.229.12 (12 Jan 2011 07:37:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 12 Jan 2011 07:37:18 +0000 (UTC) Cc: Emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 12 08:37:13 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PcvGb-0003Hi-KS for ged-emacs-devel@m.gmane.org; Wed, 12 Jan 2011 08:37:13 +0100 Original-Received: from localhost ([127.0.0.1]:51031 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcvGb-0003IF-3l for ged-emacs-devel@m.gmane.org; Wed, 12 Jan 2011 02:37:13 -0500 Original-Received: from [140.186.70.92] (port=48949 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcvGT-0003I1-Fg for Emacs-devel@gnu.org; Wed, 12 Jan 2011 02:37:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PcvGR-0005y0-DR for Emacs-devel@gnu.org; Wed, 12 Jan 2011 02:37:05 -0500 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:12004) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PcvGR-0005xY-8H for Emacs-devel@gnu.org; Wed, 12 Jan 2011 02:37:03 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 1594078017C3; Wed, 12 Jan 2011 08:37:02 +0100 (CET) Original-Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 18313-06; Wed, 12 Jan 2011 08:37:01 +0100 (CET) X-CHKRCPT: Envelopesender noch tassilo@member.fsf.org Original-Received: from thinkpad (tsdh.uni-koblenz.de [141.26.67.142]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 28EAD7801790; Wed, 12 Jan 2011 08:37:01 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Tue, 11 Jan 2011 20:47:05 -0500") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-Virus-Scanned: amavisd-new at uni-koblenz.de X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:134458 Archived-At: Stefan Monnier writes: >> + /* MagickWandGenesis() initializes the imagemagick library. */ > > Nitpick: "MagickWandGenesis()" refers to the value returned by the > function, and that value doesn't initialize anything. It should say > > /* `MagickWandGenesis' initializes the imagemagick library. */ > > instead. Ok, fixed. I also added an equivalent comment to the MagickWandTerminus call for reasons of symmetry. Bye, Tassilo