From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: bug in copy-directory Date: Tue, 08 Feb 2011 10:18:40 +0100 Message-ID: <87pqr2c2a7.fsf@gmx.de> References: <87ipxaidea.fsf@gmail.com> <878vy59ejz.fsf@stupidchicken.com> <87lj23ickn.fsf@stupidchicken.com> <87sjway8i3.fsf@gmx.de> <87wrll2ebe.fsf@stupidchicken.com> <87hbcot7gq.fsf@gmx.de> <87ei7qrdp0.fsf@gmail.com> <87ipx2dayh.fsf@gmx.de> <87y65yyxfu.fsf@gmail.com> <87d3n8xkeq.fsf@gmail.com> <878vxw6r4m.fsf@gmx.de> <87pqr790b0.fsf@gmail.com> <87oc6r7gjc.fsf@gmx.de> <87ipwz8t92.fsf@gmail.com> <878vxt69k7.fsf@stupidchicken.com> <874o8hbc9q.fsf@gmx.de> <87tygh8ez6.fsf@stupidchicken.com> <87zkq7okvk.fsf@gmx.de> <87vd0vwy0k.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297156748 7489 80.91.229.12 (8 Feb 2011 09:19:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 8 Feb 2011 09:19:08 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 08 10:19:04 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pmjix-0004wA-Hr for ged-emacs-devel@m.gmane.org; Tue, 08 Feb 2011 10:19:03 +0100 Original-Received: from localhost ([127.0.0.1]:35763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pmjiw-000272-Gr for ged-emacs-devel@m.gmane.org; Tue, 08 Feb 2011 04:19:02 -0500 Original-Received: from [140.186.70.92] (port=51753 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pmjih-00026D-Pc for emacs-devel@gnu.org; Tue, 08 Feb 2011 04:18:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pmjig-00047J-KU for emacs-devel@gnu.org; Tue, 08 Feb 2011 04:18:47 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.22]:48075) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1Pmjig-000476-AO for emacs-devel@gnu.org; Tue, 08 Feb 2011 04:18:46 -0500 Original-Received: (qmail invoked by alias); 08 Feb 2011 09:18:44 -0000 Original-Received: from p57BB90E5.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.144.229] by mail.gmx.net (mp046) with SMTP; 08 Feb 2011 10:18:44 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1+hL49m47uh7zwC9KZIFI063pB4Zkzh4yEnHBsPql julNFWEa7Riq59 In-Reply-To: <87vd0vwy0k.fsf@gmail.com> (Thierry Volpiatto's message of "Mon, 07 Feb 2011 18:32:59 +0100") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 213.165.64.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135734 Archived-At: Thierry Volpiatto writes: > Michael, could you apply the patch i sent here to Stefan and do: > > M-: (copy-directory "/tmp/test" "~/") RET > > You will see it works fine. Yes. > M-x copy-directory works fine too > > and copying from dired works fine also. Yes. However, when copying in dired "/tmp/test" to "~/", the second attempt results in a wrong directory structure. For file name handlers your approach is a little bit, hmm, surprising. You call the handler for `copy-directory' inside of `copy-directory1'. This could work, or course, but it isn't a clean approach, and it will add a maintenance burden when all of us have forgotten what we are doing here. At least *I* am pretty good in forgetting (my wife says :-) Best regards, Michael.