From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: Please don't use revision numbers on commit messages (and elsewhere). Date: Fri, 01 Apr 2011 02:20:26 +0200 Message-ID: <87pqp6vn3p.fsf@wanadoo.es> References: <877hbfvwyo.fsf@wanadoo.es> <87sju2hoee.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1301617249 19954 80.91.229.12 (1 Apr 2011 00:20:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 1 Apr 2011 00:20:49 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 01 02:20:46 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5S6Y-00045X-5n for ged-emacs-devel@m.gmane.org; Fri, 01 Apr 2011 02:20:46 +0200 Original-Received: from localhost ([127.0.0.1]:36423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5S6X-0001PW-JV for ged-emacs-devel@m.gmane.org; Thu, 31 Mar 2011 20:20:45 -0400 Original-Received: from [140.186.70.92] (port=53376 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5S6S-0001M3-JR for emacs-devel@gnu.org; Thu, 31 Mar 2011 20:20:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5S6Q-0002sx-V3 for emacs-devel@gnu.org; Thu, 31 Mar 2011 20:20:40 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:35124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5S6Q-0002sh-LP for emacs-devel@gnu.org; Thu, 31 Mar 2011 20:20:38 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Q5S6P-000432-64 for emacs-devel@gnu.org; Fri, 01 Apr 2011 02:20:37 +0200 Original-Received: from 131.red-83-59-5.dynamicip.rima-tde.net ([83.59.5.131]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 01 Apr 2011 02:20:37 +0200 Original-Received: from ofv by 131.red-83-59-5.dynamicip.rima-tde.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 01 Apr 2011 02:20:37 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 32 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 131.red-83-59-5.dynamicip.rima-tde.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:6eCyCbRGR6JGfhfbvJda/UaVOUI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137961 Archived-At: Thien-Thi Nguyen writes: > please use the revision id, which is unique for every commit. > > I think it would both more vcs-agnostic and programmer-friendly to use a > date and commit title (presuming the commit has one). For example: > > 2011-03-31 Thien-Thi Nguyen > > [lib] Fix bug: Reorder #include "libserveez/foo.h" in libserveez.h. > > Regression (due to omission) introduced 2011-03-04, > "Mark #include "libservez/foo.h" as internal". > Lesson: Take care when discarding dependency (ordering) info! > > * libserveez.h: Move ‘pipe-socket’ and ‘portcfg’ before ‘cfg’. > > Here, the date is 2011-03-04, and the title is "Mark ... internal". > These two pieces of info are usually sufficient to uniquely identify a > particular change, and a nice side benefit is that the window of the bug > is apparently computable (in this example almost four weeks -- eep!). Your proposal is much better than using revision numbers, IMO. It is actually informative, although it makes difficult to pinpoint the mentioned revision or to answer the question "is the mentioned revision on branch X?" which is automatic when you have a revision id. A different issue is to convince people to write proper commit messages, with the first line acting as the commit title. But that is another battle. [snip]