unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Óscar Fuentes" <ofv@wanadoo.es>
To: emacs-devel@gnu.org
Subject: Re: Please don't use revision numbers on commit messages (and elsewhere).
Date: Fri, 01 Apr 2011 02:20:26 +0200	[thread overview]
Message-ID: <87pqp6vn3p.fsf@wanadoo.es> (raw)
In-Reply-To: 87sju2hoee.fsf@ambire.localdomain

Thien-Thi Nguyen <ttn@gnuvola.org> writes:

>    please use the revision id, which is unique for every commit.
>
> I think it would both more vcs-agnostic and programmer-friendly to use a
> date and commit title (presuming the commit has one).  For example:
>
>   2011-03-31  Thien-Thi Nguyen  <ttn@gnuvola.org>
>   
>   	[lib] Fix bug: Reorder #include "libserveez/foo.h" in libserveez.h.
>   
>   	Regression (due to omission) introduced 2011-03-04,
>   	"Mark #include "libservez/foo.h" as internal".
>   	Lesson: Take care when discarding dependency (ordering) info!
>   
>   	* libserveez.h: Move ‘pipe-socket’ and ‘portcfg’ before ‘cfg’.
>   
> Here, the date is 2011-03-04, and the title is "Mark ... internal".
> These two pieces of info are usually sufficient to uniquely identify a
> particular change, and a nice side benefit is that the window of the bug
> is apparently computable (in this example almost four weeks -- eep!).

Your proposal is much better than using revision numbers, IMO. It is
actually informative, although it makes difficult to pinpoint the
mentioned revision or to answer the question "is the mentioned revision
on branch X?" which is automatic when you have a revision id.

A different issue is to convince people to write proper commit messages,
with the first line acting as the commit title. But that is another
battle.

[snip]




  reply	other threads:[~2011-04-01  0:20 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-31 20:47 Please don't use revision numbers on commit messages (and elsewhere) Óscar Fuentes
2011-03-31 21:36 ` Lennart Borgman
2011-03-31 21:53   ` Óscar Fuentes
2011-03-31 21:59     ` Lennart Borgman
2011-03-31 22:06       ` Óscar Fuentes
2011-03-31 22:18         ` Lennart Borgman
2011-03-31 22:58       ` Juanma Barranquero
2011-04-01  7:42   ` Eli Zaretskii
2011-04-01  7:58     ` Andreas Schwab
2011-04-01  8:02       ` Eli Zaretskii
2011-04-01  8:17         ` Andreas Schwab
2011-04-01  8:42           ` Eli Zaretskii
2011-04-01  8:54             ` Andreas Schwab
2011-04-01 10:11               ` Eli Zaretskii
2011-04-01 10:21                 ` Andreas Schwab
2011-04-01 10:48                   ` Eli Zaretskii
2011-04-01 11:18                     ` Andreas Schwab
2011-04-01 13:15                       ` Eli Zaretskii
2011-04-01 13:32                         ` Andreas Schwab
2011-04-01 13:47                           ` Eli Zaretskii
2011-04-01 13:51                             ` Deniz Dogan
2011-04-01 15:26         ` Óscar Fuentes
2011-04-01 19:13           ` Eli Zaretskii
2011-04-01 20:17             ` Óscar Fuentes
2011-03-31 23:14 ` Juanma Barranquero
2011-04-01  0:11   ` Óscar Fuentes
2011-04-01  0:28     ` Juanma Barranquero
2011-04-01  1:20       ` Óscar Fuentes
2011-04-01  8:18         ` Eli Zaretskii
2011-04-01 12:08           ` David Kastrup
2011-04-01 13:15             ` Eli Zaretskii
2011-04-01 15:35           ` Óscar Fuentes
2011-04-01 19:52             ` Eli Zaretskii
2011-04-01 20:04               ` David Kastrup
2011-04-01 20:36                 ` Eli Zaretskii
2011-04-01 20:43               ` Óscar Fuentes
2011-04-01 10:34         ` Juanma Barranquero
2011-04-01 15:55           ` Óscar Fuentes
2011-04-01 21:53             ` Juanma Barranquero
2011-04-04 16:32           ` Nils Ackermann
2011-04-04 21:27             ` Juanma Barranquero
2011-04-04 21:36               ` Lennart Borgman
2011-04-04 21:49                 ` Juanma Barranquero
2011-04-04 22:03                   ` Lennart Borgman
2011-04-04 22:09                     ` Juanma Barranquero
2011-04-04 22:27               ` Stefan Monnier
2011-04-04 22:35                 ` Juanma Barranquero
2011-04-05 21:00                   ` Thien-Thi Nguyen
2011-04-05 21:00                   ` Thien-Thi Nguyen
2011-04-06  1:30                     ` Stefan Monnier
2011-04-06  2:55                       ` Stephen J. Turnbull
2011-04-06 12:47                         ` Thien-Thi Nguyen
2011-04-01  1:59       ` Stephen J. Turnbull
2011-04-01 10:00         ` Uday S Reddy
2011-04-01 15:00           ` Stephen J. Turnbull
2011-04-01 16:38             ` Uday S Reddy
2011-04-01 18:08               ` Stephen J. Turnbull
2011-04-01 18:56                 ` Uday S Reddy
2011-04-01 20:49                   ` Stephen J. Turnbull
2011-04-01 10:45         ` Juanma Barranquero
2011-04-01 14:51           ` Stefan Monnier
2011-04-01 15:14             ` Ted Zlatanov
2011-04-01 19:58             ` Juanma Barranquero
2011-04-02  2:12     ` Chong Yidong
2011-04-01  1:35   ` Stephen J. Turnbull
2011-04-01 10:39     ` Juanma Barranquero
2011-03-31 23:16 ` Thien-Thi Nguyen
2011-04-01  0:20   ` Óscar Fuentes [this message]
2011-04-01  8:38     ` Thien-Thi Nguyen
2011-04-01  9:36       ` Eli Zaretskii
2011-04-01 10:14         ` Eli Zaretskii
2011-04-01 17:38           ` Thien-Thi Nguyen
2011-04-01 15:38         ` Óscar Fuentes
2011-04-01 19:12           ` Eli Zaretskii
2011-04-01 20:21             ` Óscar Fuentes
2011-04-01 20:38               ` Eli Zaretskii
2011-04-01 21:40               ` Uday S Reddy
2011-04-02  0:03                 ` Óscar Fuentes
2011-04-02  6:20                   ` Uday S Reddy
2011-04-02 13:47                     ` Óscar Fuentes
2011-04-03  8:00                       ` Uday S Reddy
2011-04-03 16:13                         ` Óscar Fuentes
2011-04-04  9:29                           ` Uday S Reddy
2011-04-05  2:20                             ` Stephen J. Turnbull
2011-04-02  2:57                 ` Stephen J. Turnbull
2011-04-01  0:55 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pqp6vn3p.fsf@wanadoo.es \
    --to=ofv@wanadoo.es \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).