unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Nix <nix@esperi.org.uk>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [RFC PATCH] setting indentation styles via `c-file-style' fails to actually change indentation
Date: Wed, 18 May 2011 21:28:34 +0100	[thread overview]
Message-ID: <87pqnfu51p.fsf@spindle.srvr.nix> (raw)
In-Reply-To: <jwvei3w6f1w.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 17 May 2011 21:17:50 -0300")

On 18 May 2011, Stefan Monnier outgrape:
> But I just want to take the opportunity to say that all this CC style
> business is much too complex for its own sake, and as a result we've
> seen and keep seeing new problems that require additional hacks on top
> of hacks to try and "fix" things.

Gods, yes. Most of this appears to be the interaction of backward-
compatibility kludge atop backward-compatibility kludge.

The indentation engine works great (the most nearly flawless I've ever
seen), and the style engine needs a certain degree of complexity --
things like inherited styles are a must, because so many styles in the
real world are almost like one of cc-mode's except for a couple of tiny
differences.

But the support for configuration through global variables *or* styles,
with styles possibly taking effect by localizing variables in one buffer
or possibly taking effect by making them local to all buffers... well,
it's just ridiculous. Rip out all that stuff and use the recommended
configuration only (style variables automatically localized to the
current buffer, direct setting of style variables always overrides the
style itself via 'set-from-style) and ditch all the rest. I'm fairly
sure that half the configurations implied by the current set of
variables are broken at any one time, because there are so many that
nobody can really test them.

(That's an alternative: a decent testing framework for this stuff, such
that we could be sure it didn't break. Then it wouldn't matter so much
how complex it got, except insofar as it bends the brains of people
trying to look at the code.)

-- 
NULL && (void)



  reply	other threads:[~2011-05-18 20:28 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-17 23:21 [RFC PATCH] setting indentation styles via `c-file-style' fails to actually change indentation Nix
2011-05-18  0:17 ` Stefan Monnier
2011-05-18 20:28   ` Nix [this message]
2011-05-18 21:08     ` ERT indentation testing (was: [RFC PATCH] setting indentation styles via `c-file-style' fails to actually change indentation) Ted Zlatanov
2011-05-18 22:19       ` ERT indentation testing Stefan Monnier
2011-05-19 10:33         ` Ted Zlatanov
2011-05-19 11:56           ` Stefan Monnier
2011-06-01 21:30             ` Ted Zlatanov
2011-06-02 18:43               ` Ted Zlatanov
2011-06-03  0:04                 ` Stefan Monnier
2011-06-03 11:33                   ` Ted Zlatanov
2011-06-03 12:12                     ` martin rudalics
2011-06-03 15:06                       ` extra-interactive functions (was: ERT indentation testing) Ted Zlatanov
2011-06-03 15:27                         ` extra-interactive functions martin rudalics
2011-06-03 16:11                           ` Ted Zlatanov
2011-06-03 18:59                             ` martin rudalics
2011-06-03 19:10                               ` Ted Zlatanov
2011-06-03 20:54                                 ` martin rudalics
2011-06-08 10:44                 ` ERT indentation testing Ted Zlatanov
2011-06-08 15:24                   ` Stefan Monnier
2011-06-09 16:05                     ` Ted Zlatanov
2011-06-10 20:41                       ` Stefan Monnier
2011-06-01 14:31   ` [RFC PATCH] setting indentation styles via `c-file-style' fails to actually change indentation Nix
2011-06-02 12:24     ` Alan Mackenzie
2011-06-02 13:35       ` Stefan Monnier
2011-06-02 16:47       ` Nix
2011-06-02 21:15         ` Alan Mackenzie
2011-06-02 21:43           ` Nix
2011-06-05 15:06             ` Alan Mackenzie
2011-07-24 10:07               ` Kan-Ru Chen
2011-08-05 14:14               ` Nix
2011-05-18  3:27 ` Glenn Morris
2011-05-18 11:02   ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pqnfu51p.fsf@spindle.srvr.nix \
    --to=nix@esperi.org.uk \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).