From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar! Date: Sat, 06 Apr 2013 17:02:09 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87ppy7e5ke.fsf@lifelogs.com> References: <87y5cx0wh7.fsf@yandex.ru> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1365282156 31744 80.91.229.3 (6 Apr 2013 21:02:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Apr 2013 21:02:36 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 23:02:37 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UOaFw-0003kn-HB for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2013 23:02:36 +0200 Original-Received: from localhost ([::1]:46014 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOaFw-0003vR-2R for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2013 17:02:36 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOaFr-0003vK-Iu for emacs-devel@gnu.org; Sat, 06 Apr 2013 17:02:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOaFl-0003xk-NK for emacs-devel@gnu.org; Sat, 06 Apr 2013 17:02:31 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:35169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOaFl-0003xe-HW for emacs-devel@gnu.org; Sat, 06 Apr 2013 17:02:25 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UOaFg-0003WO-MV for emacs-devel@gnu.org; Sat, 06 Apr 2013 23:02:20 +0200 Original-Received: from pool-71-174-194-90.bstnma.east.verizon.net ([71.174.194.90]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 06 Apr 2013 23:02:20 +0200 Original-Received: from tzz by pool-71-174-194-90.bstnma.east.verizon.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 06 Apr 2013 23:02:20 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 28 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: pool-71-174-194-90.bstnma.east.verizon.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:sR1LlPGtjZb3gCUfrk8lPMe52xo= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158736 Archived-At: On Fri, 5 Apr 2013 16:51:00 -0400 Daniel Hackney wrote: DH> Dmitry Gutov wrote: >> It doesn't seem to apply cleanly to trunk, but here's the diff: >> >> https://github.com/haxney/emacs/compare/3a5be1e2bf8b8b096f7c656c99f644b7dd0c4bab...package-rewrite.diff >> >> It also has no ChangeLog entries (currently; the contents of the above >> URL will update if/when Daniel adds them). DH> I guess I'll have to rebase it off of trunk. Sorry about not giving a DH> usable diff. DH> I realized that I have a few things left to do for the patch: DH> - Create ChangeLog entries DH> - Update package-x.el. I haven't touched it and it is going to be DH> horribly broken. DH> A question: should I submit this as a single large patch or break it DH> up? It doesn't make much sense to have it broken up, since it is really DH> an all-or-nothing overhaul, but if people want it broken up, I can DH> certainly do so. In the end it should be a single commit to the Bazaar repo, and there's no reason to break it up for your audience here. Ted