From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Emacs contributions, C and Lisp Date: Wed, 19 Feb 2014 18:35:20 +0100 Organization: Organization?!? Message-ID: <87ppmjt38n.fsf@fencepost.gnu.org> References: <52FD9F1D.50205@yandex.ru> <83mwhucg1h.fsf@gnu.org> <878ute589i.fsf@fencepost.gnu.org> <83d2iqc84m.fsf@gnu.org> <87wqgxkcr9.fsf@yandex.ru> <834n41db0d.fsf@gnu.org> <52FE2985.4070703@yandex.ru> <831tz5daes.fsf@gnu.org> <8738jlohd6.fsf@yandex.ru> <83txc1bl83.fsf@gnu.org> <5300189A.9090208@yandex.ru> <83wqgv9fbj.fsf@gnu.org> <20140216180712.236069f6@forcix.jorgenschaefer.de> <83sirj9cyp.fsf@gnu.org> <20140217203145.71a849f7@forcix.jorgenschaefer.de> <837g8t8ouc.fsf@gnu.org> <20140219080524.25689b6b@forcix.jorgenschaefer.de> <87fvnfqyfv.fsf@fencepost.gnu.org> <874n3vauik.fsf@newcastle.ac.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1392831390 32019 80.91.229.3 (19 Feb 2014 17:36:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Feb 2014 17:36:30 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 19 18:36:39 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WGB4X-0003H6-OP for ged-emacs-devel@m.gmane.org; Wed, 19 Feb 2014 18:36:37 +0100 Original-Received: from localhost ([::1]:60979 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGB4X-00027Y-B8 for ged-emacs-devel@m.gmane.org; Wed, 19 Feb 2014 12:36:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGB3b-0000uq-0o for emacs-devel@gnu.org; Wed, 19 Feb 2014 12:35:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGB3V-0003l2-DO for emacs-devel@gnu.org; Wed, 19 Feb 2014 12:35:38 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:44506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGB3V-0003kt-0A for emacs-devel@gnu.org; Wed, 19 Feb 2014 12:35:33 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WGB3S-0001HS-Rq for emacs-devel@gnu.org; Wed, 19 Feb 2014 18:35:30 +0100 Original-Received: from x2f44deb.dyn.telefonica.de ([2.244.77.235]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 19 Feb 2014 18:35:30 +0100 Original-Received: from dak by x2f44deb.dyn.telefonica.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 19 Feb 2014 18:35:30 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 48 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: x2f44deb.dyn.telefonica.de X-Face: 2FEFf>]>q>2iw=B6, xrUubRI>pR&Ml9=ao@P@i)L:\urd*t9M~y1^:+Y]'C0~{mAl`oQuAl \!3KEIp?*w`|bL5qr,H)LFO6Q=qx~iH4DN; i"; /yuIsqbLLCh/!U#X[S~(5eZ41to5f%E@'ELIi$t^ Vc\LWP@J5p^rst0+('>Er0=^1{]M9!p?&:\z]|;&=NP3AhB!B_bi^]Pfkw User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:SBia/Z6sNugmJElkJZbkeGRj1Xs= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169768 Archived-At: phillip.lord@newcastle.ac.uk (Phillip Lord) writes: > David Kastrup writes: >> I've never learnt working with Bzr and never checked out the Emacs >> repository with it. >> >> That did not preclude me from sending the occasional patch to the list, >> based on the Git mirror of the Emacs repository. > > etc/CONTRIBUTE doesn't mention this. It states for the source code: * Getting the Source Code The latest version of Emacs can be downloaded using Bazaar from the Savannah web site. It is important to write your patch based on the latest version. If you start from an older version, your patch may be outdated (so that maintainers will have a hard time applying it), or changes in Emacs may have made your patch unnecessary. After you have downloaded the repository source, you should read the file INSTALL.REPO for build instructions (they differ to some extent from a normal build). Ref: http://savannah.gnu.org/projects/emacs and that reference is equally valid for Bzr and Git. For the patch, you get ** The patch itself. If you are accessing the Bazaar repository, make sure your copy is up-to-date (e.g. with `bzr pull'), then use bzr diff --no-aliases --diff-options=-cp Else, use diff -cp OLD NEW As you see there is an _explicit_ recipe for creating a patch without using Bzr. With regard to git, one can use C-u C-x v = to create a patch, and if one wants to be really RMS-compatible, C-u C-c C-u in the *vc-diff* buffer will convert it into a context diff. It turns out that most Emacs developers nowadays are fine with unified diffs, however. -- David Kastrup