From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 71783e9: Add the string-numeric-lessp function Date: Mon, 22 Feb 2016 13:53:35 +1100 Message-ID: <87povpzc9c.fsf@gnus.org> References: <20160221043348.25201.81719@vcs.savannah.gnu.org> <87twl2fzaw.fsf@gnus.org> <56CA2C66.7040306@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456110100 1062 80.91.229.3 (22 Feb 2016 03:01:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Feb 2016 03:01:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 22 04:01:30 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aXgka-0003ag-3A for ged-emacs-devel@m.gmane.org; Mon, 22 Feb 2016 04:01:28 +0100 Original-Received: from localhost ([::1]:46280 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXgkZ-0001Jc-Kk for ged-emacs-devel@m.gmane.org; Sun, 21 Feb 2016 22:01:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXgdV-00047B-7c for emacs-devel@gnu.org; Sun, 21 Feb 2016 21:54:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXgdP-0001Hz-JI for emacs-devel@gnu.org; Sun, 21 Feb 2016 21:54:09 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:44158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXgdP-0001Hu-Cq for emacs-devel@gnu.org; Sun, 21 Feb 2016 21:54:03 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aXgd1-0008UG-P2; Mon, 22 Feb 2016 03:53:40 +0100 In-Reply-To: <56CA2C66.7040306@cs.ucla.edu> (Paul Eggert's message of "Sun, 21 Feb 2016 13:30:14 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aXgd1-0008UG-P2 MailScanner-NULL-Check: 1456714421.3542@Ee6yg3A+pgn5mMMp9bq+xg X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200423 Archived-At: Paul Eggert writes: > Thanks, I did that. The idea of my followup is to use the same > algorithm that GNU ls -v does, rather than invent yet another file > name comparison algorithm. This should also handle very long integers > correctly. I also changed the name to be more like the names used > elsewhere. Please feel free to revert. Looks nice, but I don't think that's a very good function name. It sounds like something that is only meant to be used for version strings, instead of something that happens to work on version strings as well.. And is this supposed to be this way? (string-version-lessp "foo001.png" "foo1.png") => t -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no