From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mitchel Humpherys Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region Date: Mon, 14 Mar 2016 10:22:29 -0700 Message-ID: <87poux9dpm.fsf@gmail.com> References: <1456189471-18273-1-git-send-email-mitch.special@gmail.com> <87egbxid4e.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457976292 25078 80.91.229.3 (14 Mar 2016 17:24:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Mar 2016 17:24:52 +0000 (UTC) Cc: Kristoffer Gronlund , emacs-devel@gnu.org To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 14 18:24:51 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1afWEa-0005bu-O5 for ged-emacs-devel@m.gmane.org; Mon, 14 Mar 2016 18:24:48 +0100 Original-Received: from localhost ([::1]:42684 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afWEa-0003he-4M for ged-emacs-devel@m.gmane.org; Mon, 14 Mar 2016 13:24:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afWEL-0003hE-6r for emacs-devel@gnu.org; Mon, 14 Mar 2016 13:24:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afWEG-0004PZ-9H for emacs-devel@gnu.org; Mon, 14 Mar 2016 13:24:33 -0400 Original-Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:33581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afWEF-0004P8-TO for emacs-devel@gnu.org; Mon, 14 Mar 2016 13:24:28 -0400 Original-Received: by mail-pa0-x230.google.com with SMTP id fl4so160754886pad.0 for ; Mon, 14 Mar 2016 10:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+YvtxhgtChoTPm94SfSnehSi4dmmAquhkM/eFbLIj7U=; b=fvFXM8En8RH++Zl0UJvzEzIMBEdHfD1MDid/anpoU5960muN6JDi/4niUPVyRySqxq VJ2k3+AcdDowRItkxJ8aCoVpwJnrIu7auLSSLwpyl5ZwAXqJyw2OYJf1AONnt7V9L7eg XP57VaM2zE4YPkeO1ckuzs29PMM5Nfbc+5hqL/gUexvycr68VF4eMkSxu9LXb/v08nsJ zd3nEHS3dSFb4uZXd6Zi80v3idg8k3C3P6r3+jK3GlEbXu8VIbzzex9bjk6LZc4lOaEE fwd/NeWsJdj8ZWBTJR35oQPbSIZMo4fcsYrVOIz5DZfF5dhfF+6ctNsjiz0zznJD02bl XqPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+YvtxhgtChoTPm94SfSnehSi4dmmAquhkM/eFbLIj7U=; b=GSdaWdem/8sPA77p7rumh5N+mtXoylpZIats16d0Kr2C0jhFT2Pj8K8LHntbCY2+Gv K8tgyii9psef10msHg1nSLdWHUY4K7yNQ1eh9BH67FUXcCAOjlBvnGsw0b2j3/+1/6rG 5hRx4xxkAd1Xj6bThRj6ssREmO3KI2VvUb9q/Gna2Ej/1dDSgFLpzTqduofMuppVxF53 sKfQLAVTi5mLh7ZRfB0iNAEKgTFugueuN48l3mMaAbMlQal9N6YN/aVQjoAasvBz1AKZ ZyD2LdOsxEgQZnSGzPHwnuAcIWl4LsYTLtOpxfTQ4JnjMtQwmb03bdhsGD279p/78DFS gS3g== X-Gm-Message-State: AD7BkJL8OPx+Nt+cJu7sHXsBpSq7KasnmMqXqMaUpXMJyKYZ9mcWpveUU6zJTxAR7GK+RQ== X-Received: by 10.66.139.137 with SMTP id qy9mr39812976pab.57.1457976266814; Mon, 14 Mar 2016 10:24:26 -0700 (PDT) Original-Received: from space ([2600:8801:f900:f34:d59b:8fe9:9a45:b223]) by smtp.gmail.com with ESMTPSA id 3sm33542231pfn.59.2016.03.14.10.24.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Mar 2016 10:24:26 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Sun, 28 Feb 2016 07:53:45 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201719 Archived-At: On Sun, Feb 28 2016 at 06:53:45 AM, Drew Adams wrote: >> > Setting a foreground color on the `region' face is slightly >> > annoying. >> > This is subjective, of course, but the consensus among other >> > themes and around the web is to *not* set a foreground color >> > on the region face. >> >> Any objections to this? I should have mentioned that the reason >> it's slightly annoying is because setting a foreground color hides >> existing syntax highlighting within the region text. > > A particular theme can do anything its authors and users want, > of course. But wrt the general question of whether region (aka > selection) highlighting should override other highlighting, see > Emacs bug #15899. > > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15899 > > IMO, selection highlighting should, at least by default, visibly > cover the entire selection. Otherwise, it is not always clear > what the region limits are. Just to be clear, when I said "syntax highlighting" I meant it in the general sense of colors applied to the *foreground* of code in order to highlight the syntax of the language. I believe you're referring to background highlighting, which shouldn't be affected by this patch. -- Mitch