* Re: [Emacs-diffs] master 65797b1: Make icomplete respect `completion-ignored-extensions'
[not found] ` <E1avpnd-0000xB-Qt@vcs.savannah.gnu.org>
@ 2016-04-28 19:09 ` Stefan Monnier
2016-04-28 21:37 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2016-04-28 19:09 UTC (permalink / raw)
To: emacs-devel; +Cc: Drew Adams
> --- a/lisp/icomplete.el
> +++ b/lisp/icomplete.el
> @@ -388,6 +388,9 @@ matches exist."
> (progn ;;(debug (format "Candidates=%S field=%S" candidates name))
> (format " %sNo matches%s" open-bracket close-bracket))
> (if last (setcdr last nil))
> + (when (and minibuffer-completing-file-name
> + icomplete-with-completion-tables)
> + (setq comps (completion-pcm--filename-try-filter comps)))
> (let* ((most-try
> (if (and base-size (> base-size 0))
> (completion-try-completion
Yuck. We should really extend completion-tables yet a bit more
(probably via the completion-metadata or completion-extra-properties) so
we don't need to check minibuffer-completing-file-name and we can use
similar features in other completions.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Emacs-diffs] master 65797b1: Make icomplete respect `completion-ignored-extensions'
2016-04-28 19:09 ` [Emacs-diffs] master 65797b1: Make icomplete respect `completion-ignored-extensions' Stefan Monnier
@ 2016-04-28 21:37 ` Lars Ingebrigtsen
2016-04-30 13:33 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2016-04-28 21:37 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Drew Adams, emacs-devel
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> --- a/lisp/icomplete.el
>> +++ b/lisp/icomplete.el
>> @@ -388,6 +388,9 @@ matches exist."
>> (progn ;;(debug (format "Candidates=%S field=%S" candidates name))
>> (format " %sNo matches%s" open-bracket close-bracket))
>> (if last (setcdr last nil))
>> + (when (and minibuffer-completing-file-name
>> + icomplete-with-completion-tables)
>> + (setq comps (completion-pcm--filename-try-filter comps)))
>> (let* ((most-try
>> (if (and base-size (> base-size 0))
>> (completion-try-completion
>
> Yuck. We should really extend completion-tables yet a bit more
> (probably via the completion-metadata or completion-extra-properties) so
> we don't need to check minibuffer-completing-file-name and we can use
> similar features in other completions.
Should I revert the patch?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 65797b1: Make icomplete respect `completion-ignored-extensions'
2016-04-28 21:37 ` Lars Ingebrigtsen
@ 2016-04-30 13:33 ` Stefan Monnier
2016-04-30 14:22 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2016-04-30 13:33 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Drew Adams, emacs-devel
>> Yuck. We should really extend completion-tables yet a bit more
>> (probably via the completion-metadata or completion-extra-properties) so
>> we don't need to check minibuffer-completing-file-name and we can use
>> similar features in other completions.
> Should I revert the patch?
No, that "yucky stuff" is already present at other places in
minibuffer.el. Your patch didn't make it significantly worse.
It should makes it yet a bit more obvious that a better solution is
called for.
I didn't add a solution to this problem originally because it seemed to
be a lot of trouble, but in the mean time I added the
completion-metadata and completion-extra-properties stuff, so I think it
should be reasonably easy now to use those to implement that
new feature.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-30 14:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160428173225.3631.60149@vcs.savannah.gnu.org>
[not found] ` <E1avpnd-0000xB-Qt@vcs.savannah.gnu.org>
2016-04-28 19:09 ` [Emacs-diffs] master 65797b1: Make icomplete respect `completion-ignored-extensions' Stefan Monnier
2016-04-28 21:37 ` Lars Ingebrigtsen
2016-04-30 13:33 ` Stefan Monnier
2016-04-30 14:22 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).