From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695). Date: Thu, 16 Jun 2016 11:11:00 +0200 Message-ID: <87porh1ot7.fsf@gmx.net> References: <20160614214332.2901.16184@vcs.savannah.gnu.org> <20160614214332.C030F220116@vcs.savannah.gnu.org> <87h9cuyeip.fsf@gmx.net> <87d1nixzcu.fsf@gmx.net> <83ziqmcwe8.fsf@gnu.org> <874m8ucoh5.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466069833 29662 80.91.229.3 (16 Jun 2016 09:37:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Jun 2016 09:37:13 +0000 (UTC) Cc: Eli Zaretskii , Stefan Monnier , emacs-devel@gnu.org To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 16 11:37:04 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDTjT-0004iu-TW for ged-emacs-devel@m.gmane.org; Thu, 16 Jun 2016 11:37:04 +0200 Original-Received: from localhost ([::1]:47594 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDTjT-000562-0B for ged-emacs-devel@m.gmane.org; Thu, 16 Jun 2016 05:37:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDTKh-0004E0-Gn for emacs-devel@gnu.org; Thu, 16 Jun 2016 05:11:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDTKf-00086e-LV for emacs-devel@gnu.org; Thu, 16 Jun 2016 05:11:26 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:59388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDTKZ-00085Q-U6; Thu, 16 Jun 2016 05:11:20 -0400 Original-Received: from rosalinde ([89.245.103.82]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0Lm6IP-1bn57u05E9-00ZdVg; Thu, 16 Jun 2016 11:11:03 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-Provags-ID: V03:K0:W6h0t7sIYyjj8uTGj7O0nCOH1oXLdlsPw6adQ2ePsh0T+4VY4iW /pRwEa8swcGiJgzbr0hfFOcaAhUppB/GQ3DOnsjVkaCBaca0OAplKmM4tG5aWFf+LGYQPqo v5A7CkHV9upyqXCJ+gt3TafNgsJBRJBGhIOil8VMSkcPTOPT10zpgykWQwfETMURn5HbZV1 FT2UoiVvOz4qQY7ntN6CQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:hcytm026LQk=:5cslygFN3BfiO6hNj/vzkp a71TZN6Ti5E7gijtsoWOY32tDR9I2BQEEpUcvHXjDcf41rv9KugkLRAOsnVSbIGyd+Ir8wVvj S8afmpbhsUF4OwDAxYHh7/Vr2GFzM2f+iRRV0ZTJRhCMhN6UJhARUG2DpOB9sQkj+DseVh6sb IA2fuDR+fzznX7M3Fx/gN9Fpiaszot6EccunSmz9FzqlC8a5Nm+2J41Ir+87xuUpJuysCOu+u dNs7+1YGWnSiss2tBj3G6Wrc/Q+Rta9jFAsxsLWP/19ztTZOHrxLc6wauzXLs13bLrLwzEuNX XMrIMln8rpXo2FMkEJxYIvftvJtF3atJzxKOpGx1diWm2oNeDOyD2h9bLs4tvd86imkcAtHab +9PKBTxfLOedqL13kwUpssyCFM3dRtVsF8Oc69ZJTzf9iN09MwLtuP4NEgtZr4wOz72Y5P5VM Ey9mhYbp6EJfEWOAlZCCX4zqoBbQVP01IFM0gq+80oydAM0TOALSQN9qOAwNRVYEtneEhVZos ispIZzvv49Z0qna2uyLQ5J2+9uvszsmIfRv+uaGh5drHq0X98RMgUqmkLu5a7NB+sM0aJYpGk t7lKrzHxFu3H3aLhic3YwMft5ik7gJ49YAqBeRgSJkEOKeAAucxGr51QrdtleZsPVEgHBsECC +rNq/wxzgM6zNlSA8KYeqBlMrWR1x3+7rkX/qF5Er2rOOLQVVoxZJhkpFRwiPZ6JSnE4GOeeP O9cBMQXnGs0gKPhbshFe8hgxME6zmROUijDaTwJyClU3TGaCEvWbDXCgS328OCRcd3uhRVLC X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204427 Archived-At: On Wed, 15 Jun 2016 23:04:27 -0400 Noam Postavsky wrote: > On Wed, Jun 15, 2016 at 2:10 PM, Stephen Berman wrote: >> >> Thanks, done as commit 5d4d8a3. > > I think it does nothing but bind minibuffer-local-completion-map to > nil, since define-key doesn't return the map. You should have > > (let ((minibuffer-local-completion-map > (let ((map (make-sparse-keymap))) > (set-keymap-parent map minibuffer-local-completion-map) > (define-key map " " nil) > map))) ; <---------- use the map Thanks for catching that. Fix pushed to emacs-25 as commit 2317c61. (I had tested my previous change before committing it, but only that SPC worked as intended (because it is bound to the global map), and neglected the other minibuffer bindings.) Steve Berman