From: Stephen Berman <stephen.berman@gmx.net>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: Eli Zaretskii <eliz@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695).
Date: Thu, 16 Jun 2016 11:11:00 +0200 [thread overview]
Message-ID: <87porh1ot7.fsf@gmx.net> (raw)
In-Reply-To: CAM-tV-_5jYB4uxH1bgy2AtF=ZZ8LkkyvVVGgpu3jdsohn+24Lw@mail.gmail.com
On Wed, 15 Jun 2016 23:04:27 -0400 Noam Postavsky <npostavs@users.sourceforge.net> wrote:
> On Wed, Jun 15, 2016 at 2:10 PM, Stephen Berman <stephen.berman@gmx.net> wrote:
>>
>> Thanks, done as commit 5d4d8a3.
>
> I think it does nothing but bind minibuffer-local-completion-map to
> nil, since define-key doesn't return the map. You should have
>
> (let ((minibuffer-local-completion-map
> (let ((map (make-sparse-keymap)))
> (set-keymap-parent map minibuffer-local-completion-map)
> (define-key map " " nil)
> map))) ; <---------- use the map
Thanks for catching that. Fix pushed to emacs-25 as commit 2317c61. (I
had tested my previous change before committing it, but only that SPC
worked as intended (because it is bound to the global map), and
neglected the other minibuffer bindings.)
Steve Berman
next prev parent reply other threads:[~2016-06-16 9:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160614214332.2901.16184@vcs.savannah.gnu.org>
[not found] ` <20160614214332.C030F220116@vcs.savannah.gnu.org>
2016-06-15 2:12 ` [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695) Stefan Monnier
2016-06-15 9:42 ` Stephen Berman
2016-06-15 13:16 ` Stefan Monnier
2016-06-15 15:09 ` Stephen Berman
2016-06-15 15:19 ` Eli Zaretskii
2016-06-15 17:31 ` John Wiegley
2016-06-15 18:10 ` Stephen Berman
2016-06-16 3:04 ` Noam Postavsky
2016-06-16 9:11 ` Stephen Berman [this message]
2016-06-15 15:23 ` Generalizing make-composed-keymap (was: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695).) Stefan Monnier
2016-06-15 15:34 ` Generalizing make-composed-keymap Clément Pit--Claudel
2016-06-15 15:41 ` Stefan Monnier
2016-06-15 15:37 ` [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695) Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87porh1ot7.fsf@gmx.net \
--to=stephen.berman@gmx.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).