From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Edward John Steere Newsgroups: gmane.emacs.devel Subject: Re: CEDET Merge Date: Sat, 28 Jan 2017 15:45:24 +0200 Message-ID: <87poj7mh6z.fsf@gmail.com> References: <87r348ul9n.fsf@gmail.com> <87lgugm2qg.fsf@gmail.com> <87inpelu8i.fsf@gmail.com> <837f5uajlk.fsf@gnu.org> <87a8aqlqz8.fsf@gmail.com> <8360leahxr.fsf@gnu.org> <8760lelq68.fsf@gmail.com> <83wpdt8yo2.fsf@gnu.org> <87inpd650y.fsf@gmail.com> <8660ldabje.fsf@stephe-leake.org> <8737gh5sqw.fsf@gmail.com> <87k29tv0r4.fsf@engster.org> <8737gguipm.fsf@engster.org> <87h94vdj3n.fsf@gmail.com> <87o9z2sog1.fsf@engster.org> <87d1fe3hof.fsf@engster.org> <87lgtwtfuc.fsf@gmail.com> <874m0k1age.fsf@engster.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485611164 21129 195.159.176.226 (28 Jan 2017 13:46:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2017 13:46:04 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Eli Zaretskii , Stephen Leake , emacs-devel@gnu.org To: David Engster Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 28 14:46:00 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXTKD-0004cr-OL for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 14:45:53 +0100 Original-Received: from localhost ([::1]:51923 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXTKI-0001SD-Nm for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 08:45:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXTKA-0001S7-Vg for emacs-devel@gnu.org; Sat, 28 Jan 2017 08:45:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXTK6-0007kM-1e for emacs-devel@gnu.org; Sat, 28 Jan 2017 08:45:51 -0500 Original-Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:34882) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXTK5-0007kH-S0; Sat, 28 Jan 2017 08:45:45 -0500 Original-Received: by mail-wm0-x244.google.com with SMTP id d140so65239907wmd.2; Sat, 28 Jan 2017 05:45:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=z9a2sDhwEeRux8tDayP6QQKO4qMswHDJ+Ljc+FuXvk0=; b=oKyUfn5hyCl0dT660VVW/Yh6bVnSh88nUP4PgmfCD/QT1ysBX+vnb0VZJEaNKtw4mm V+ue9zF6RjnOcsranQyrU8Kx9w44GoqG8jEiwSwTTS7CuPSWQKvUI87wzLjutL/Kb9XJ rl1l0dJTxhFM0ii1hTr8weuvRAipMhOCDMYxeWhPeKi3Ur+6LawrCfy9waU9cOqWiCue AneDWo0nnWHn0D27RXKqiRNSIlWqolJE6Kc64PxmJdMkmJklEMA21TvyTqM/tRvuMw7v wZFqAB4WERWYUFKF1AqB7gdc53KtTtKZ6x2kk06OT9ljbajpsw9OzimFmS7J77O2LJ5a yj0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=z9a2sDhwEeRux8tDayP6QQKO4qMswHDJ+Ljc+FuXvk0=; b=EBAAxqzrENvdxBv3jhozj2uklegrwXgiOD9yMgNwVywUdsCws9ZZF4hllTpg2/iXtj cjXacPiMYNliZbXIKsWIkQ0SZvpzDcC7ZHEOb/mbTQ4MZZD+vbW1Y9PzlSIZyAgjTPzI +vX9EmpHze1iHQiVjXl6FKe4zaAvPYQI66shIyhLq0BiC71t1iT+H2NWjQ8OIt53Nj4r qDWMfihg5pF84DSPYAUGJcknsYXToksKMUig81rjsLRdvH4E6riO+LM+C1woTINn7Oyp L2juIg3txjkfd7dlZirFVJw0Qn6Ow3wbdxlxTDtqQhhOccegspuqTTtWgL0JB3By/bn7 WeBw== X-Gm-Message-State: AIkVDXKGyeN9YoUUDOMbH4rXblZ+sNTDBf4v8TrbpX9A9EhM/wuJOyXVpN20pviMz8RFBg== X-Received: by 10.28.93.138 with SMTP id r132mr7330350wmb.17.1485611144567; Sat, 28 Jan 2017 05:45:44 -0800 (PST) Original-Received: from edward ([41.193.194.172]) by smtp.gmail.com with ESMTPSA id q1sm9004687wmd.6.2017.01.28.05.45.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 28 Jan 2017 05:45:43 -0800 (PST) In-Reply-To: <874m0k1age.fsf@engster.org> (David Engster's message of "Fri, 27 Jan 2017 22:04:17 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211688 Archived-At: > That's totally expected. I'll take a look at them. > > -David I've just pushed another update to my branch which fixes another mistake in ia-utest, adds an include for the unit test root file and adds test resource files which I missed the first time round. I've created a local branch where I merged my branch to yours to see how we're doing. Here's what I've found after running both the unit and integration tests: * Utests in Error ** EDE Security (error "Corrupt object on disk") This is an error caused by the changes to how EIEIO objects auto load. They no longer include their parents as part of the auto load so all classes and class parents which are read from file must have their definitions loaded prior to de-serialising (this includes the entire inheritance hierarchy for the target class). I added the following requires to the body of `ede-proj-load' to rectify this (it's a total hack though): (require 'ede/proj-prog) (require 'ede/proj-aux) (require 'ede/proj-elisp) (require 'ede/proj-scheme) (require 'ede/proj-misc) (require 'ede/proj-prog) (require 'ede/proj-archive) (require 'ede/proj-shared) (require 'ede/proj-info) (require 'semantic/ede-grammar) Note that I haven't added this change here. ** Project Detection Tests I think that this also has to do with the changes to how classes are auto loaded, but I'm not sure. Running ede: project detection tests ... ERROR: (wrong-type-argument (or eieio-object class) nil obj) Running ede: project detect linux extra ... ERROR: (wrong-type-argument (or eieio-object class) nil obj) ** Test FMT (error "Cannot open tests/test-fmt.el for format tests") I debugged this one and it looks like it can't open test-fmt.el because semantic mode isn't active in Emacs lisp. ** Wisent Calculator Running wisent calculator ... ERROR: (void-function wisent-calc-utest) This function doesn't seem to exist in either repo (?) ** Waiting for Key Press Running working: wait-for-keypress ... ERROR: (void-function working-wait-for-keypress) This function doesn't seem to be in your branch. ** Interactive Test (error "Invalid face" modeline) I'm not sure where this face is defined, but it is indeed undefined during the test. ** C Parser Tests ERROR: (error "TAG INTERNAL DIFF: :prototype-flag :enum-type") Running semantic: C parser (ERT) ... ERROR: (ert-test-failed ((should (test-c-check-tags-length actual 1)) :form (test-c-check-tags-length nil 1) :value nil :explanation "Wrong number of tags. Expected: 1, actual: 0.")) Running semantic: C preprocessor ... ERROR: (error #("Found: >> int EDEPART (int b) << Expected: >> int C (int b) <<" 10 13 (face font-lock-type-face) 14 21 (face font-lock-function-name-face) 23 26 (face font-lock-type-face) 27 28 (face font-lock-variable-name-face) 47 50 (face font-lock-type-face) 51 52 (face font-lock-function-name-face) 54 57 (face font-lock-type-face) 58 59 (face font-lock-variable-name-face))) Are the new grammar files being compiled included correctly? ** Analyser Tests ERROR: (invalid-slot-name "#" :name) Haven't looked any further into this failure. ** SRecode Tests ERROR: (error "Entry # failed; expected: --[;; An includable we could use. Running srecode: fields ... ERROR: (error "Calculated size of # was not 5") Running srecode: project ... ERROR: (error "Project template not found when in project") Haven't looked into this one either. * Itests Break at first tag comparison (so they should get further when the Utests are fixed.)