From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: html, css, and js modes working together Date: Sun, 19 Mar 2017 11:30:42 -0600 Message-ID: <87pohd6unx.fsf@pokyo> References: <87o9ynarz3.fsf@tromey.com> <877f4z6i8n.fsf@tromey.com> <87poipzr0l.fsf@tromey.com> <87efz44o47.fsf@tromey.com> <87r3331hdg.fsf@tromey.com> <5a7078f5-3dbc-acc5-f293-6200e77f73b2@yandex.ru> <87inoe24d0.fsf@tromey.com> <53c6ef89-7c22-dfbb-fd7d-e5fbdbe34733@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1489944729 1179 195.159.176.226 (19 Mar 2017 17:32:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Mar 2017 17:32:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Tom Tromey , Stefan Monnier , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 19 18:32:03 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpegH-0006jZ-E4 for ged-emacs-devel@m.gmane.org; Sun, 19 Mar 2017 18:31:49 +0100 Original-Received: from localhost ([::1]:57603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpegL-0003aV-Mc for ged-emacs-devel@m.gmane.org; Sun, 19 Mar 2017 13:31:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpefi-0003aE-CS for emacs-devel@gnu.org; Sun, 19 Mar 2017 13:31:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpefe-0001ib-DP for emacs-devel@gnu.org; Sun, 19 Mar 2017 13:31:14 -0400 Original-Received: from gproxy6-pub.mail.unifiedlayer.com ([67.222.39.168]:55519) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1cpefd-0001ET-UK for emacs-devel@gnu.org; Sun, 19 Mar 2017 13:31:10 -0400 Original-Received: (qmail 25851 invoked by uid 0); 19 Mar 2017 17:30:50 -0000 Original-Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy6.mail.unifiedlayer.com with SMTP; 19 Mar 2017 17:30:50 -0000 Original-Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id xtWn1u0042f2jeq01tWqoa; Sun, 19 Mar 2017 11:30:50 -0600 X-Authority-Analysis: v=2.1 cv=Ath9goNP c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IkcTkHD0fZMA:10 a=6Iz7jQTuP9IA:10 a=vaJtXVxTAAAA:8 a=gAT6sNw3V5QBNLhh0wsA:9 a=QEXdDO2ut3YA:10 a=hCt-GehETBxEYQOojhlW:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QPCnA2rNIw7Y5fOUcXpL/h5AkWB+PlKqjPQYfKhZ44M=; b=x0zD2Oqkh7MV4OQ57IcRQK0YXx /I7oT2UCNDjLzpoCh3yzHQGX6yoqfvZW48GgY5eJbhyAB1hydMSjBJ26GSnx4YPP+5rDUL1aeqrye Bz37kLbLqt+OSidKY99vEILx4; Original-Received: from c-67-176-62-53.hsd1.co.comcast.net ([67.176.62.53]:43532 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cpefG-0004tf-UP; Sun, 19 Mar 2017 11:30:46 -0600 X-Attribution: Tom In-Reply-To: <53c6ef89-7c22-dfbb-fd7d-e5fbdbe34733@yandex.ru> (Dmitry Gutov's message of "Tue, 14 Feb 2017 03:34:38 +0200") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 67.176.62.53 X-Exim-ID: 1cpefG-0004tf-UP X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: c-67-176-62-53.hsd1.co.comcast.net (pokyo) [67.176.62.53]:43532 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 67.222.39.168 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213162 Archived-At: >>>>> "Dmitry" =3D=3D Dmitry Gutov writes: Dmitry> I do see the oddities, and it seems the wonkiness is more related to Dmitry> setting up submode regions, because when the font-lock acts up, Dmitry> indentation can fail on that line as well. I spent some time debugging this and I fixed up the fontification here. I also fixed the bug Cl=C3=A9ment found, where sub-mode fontification was being applied even in HTML comments. I've played with it quite a bit and used it on real code here, and it's more robust than before. Dmitry> Here's a broken example, for you reference. Thanks. This one works now. At this point I think I'm nearly ready to start checking things in. The current state is: * I have a bunch of small patches to change various things to use derived-mode-p rather than eq. This is needed to deal with having the new mode not be html-mode. I don't really want to test most of these (like changes in viper or cedet, about which I know very little), so I thought I'd send them for review. The changes are all very small. * Most basic functionality works, like fontification, indentation, flyspell, and comment-*. * Imenu and some other things don't work, but I think it's better to move forward with what we have than to fix every feature beforehand. I wonder if you agree. * I need to write some tests. I think this plus documentation is the last bit I need to do. * One open question is whether the new mode should run prog-mode-hook. It is sort of both a prog mode and a text mode. Tom