From: Tom Tromey <tom@tromey.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Tom Tromey <tom@tromey.com>,
Stefan Monnier <monnier@IRO.UMontreal.CA>,
emacs-devel@gnu.org
Subject: Re: html, css, and js modes working together
Date: Sun, 19 Mar 2017 11:30:42 -0600 [thread overview]
Message-ID: <87pohd6unx.fsf@pokyo> (raw)
In-Reply-To: <53c6ef89-7c22-dfbb-fd7d-e5fbdbe34733@yandex.ru> (Dmitry Gutov's message of "Tue, 14 Feb 2017 03:34:38 +0200")
>>>>> "Dmitry" == Dmitry Gutov <dgutov@yandex.ru> writes:
Dmitry> I do see the oddities, and it seems the wonkiness is more related to
Dmitry> setting up submode regions, because when the font-lock acts up,
Dmitry> indentation can fail on that line as well.
I spent some time debugging this and I fixed up the fontification here.
I also fixed the bug Clément found, where sub-mode fontification was
being applied even in HTML comments. I've played with it quite a bit
and used it on real code here, and it's more robust than before.
Dmitry> Here's a broken example, for you reference.
Thanks. This one works now.
At this point I think I'm nearly ready to start checking things in.
The current state is:
* I have a bunch of small patches to change various things to use
derived-mode-p rather than eq. This is needed to deal with having the
new mode not be html-mode. I don't really want to test most of these
(like changes in viper or cedet, about which I know very little), so I
thought I'd send them for review. The changes are all very small.
* Most basic functionality works, like fontification, indentation,
flyspell, and comment-*.
* Imenu and some other things don't work, but I think it's better to
move forward with what we have than to fix every feature beforehand.
I wonder if you agree.
* I need to write some tests. I think this plus documentation is the
last bit I need to do.
* One open question is whether the new mode should run prog-mode-hook.
It is sort of both a prog mode and a text mode.
Tom
next prev parent reply other threads:[~2017-03-19 17:30 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 20:34 html, css, and js modes working together Tom Tromey
2017-02-01 7:29 ` Clément Pit-Claudel
2017-02-07 4:33 ` Tom Tromey
2017-02-10 2:31 ` Tom Tromey
2017-02-02 14:19 ` Stefan Monnier
[not found] ` <87mvdy7f2g.fsf@tromey.com>
2017-02-07 14:33 ` Stefan Monnier
2017-02-06 3:08 ` Dmitry Gutov
2017-02-06 3:26 ` Tom Tromey
2017-02-06 3:46 ` Dmitry Gutov
2017-02-06 6:50 ` Clément Pit-Claudel
2017-02-06 14:17 ` Stefan Monnier
2017-02-06 20:25 ` Tom Tromey
2017-02-06 20:58 ` Dmitry Gutov
2017-02-06 22:42 ` Stefan Monnier
2017-02-06 23:51 ` Lennart Borgman
2017-02-07 3:40 ` Tom Tromey
2017-02-07 11:28 ` Dmitry Gutov
2017-02-09 23:45 ` Tom Tromey
2017-02-10 20:05 ` Stefan Monnier
2017-02-10 21:15 ` Tom Tromey
2017-02-10 23:45 ` Stefan Monnier
2017-02-11 17:46 ` Tom Tromey
2017-02-11 20:20 ` Stefan Monnier
2017-02-12 16:17 ` Dmitry Gutov
2017-02-12 16:20 ` Dmitry Gutov
2017-02-12 16:52 ` Tom Tromey
2017-02-13 1:12 ` Dmitry Gutov
2017-02-13 1:59 ` Dmitry Gutov
2017-02-13 2:48 ` Tom Tromey
2017-02-14 1:34 ` Dmitry Gutov
2017-03-19 17:30 ` Tom Tromey [this message]
2017-03-21 9:15 ` Dmitry Gutov
2017-03-24 3:18 ` Tom Tromey
2017-03-24 12:02 ` Stefan Monnier
2017-03-24 12:08 ` Toon Claes
2017-03-24 12:59 ` Noam Postavsky
2017-03-24 14:17 ` Tom Tromey
2017-04-05 22:01 ` Tom Tromey
2017-04-06 2:28 ` Leo Liu
2017-04-06 14:12 ` Dmitry Gutov
2017-02-11 17:39 ` Tom Tromey
2017-02-11 19:48 ` Stefan Monnier
2017-02-12 3:49 ` Tom Tromey
2017-02-12 5:26 ` Stefan Monnier
2017-02-12 6:14 ` Tom Tromey
2017-02-12 7:02 ` Stefan Monnier
2017-02-12 7:22 ` Tom Tromey
2017-02-12 11:14 ` martin rudalics
2017-02-12 16:01 ` Eli Zaretskii
2017-02-12 16:32 ` Tom Tromey
2017-02-12 17:14 ` Stefan Monnier
2017-02-12 17:36 ` Tom Tromey
2017-02-12 18:17 ` Eli Zaretskii
2017-02-12 16:59 ` Stefan Monnier
2017-02-11 0:28 ` Please ack Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pohd6unx.fsf@pokyo \
--to=tom@tromey.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).