From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] json: Add support for encoding structs Date: Mon, 24 Apr 2017 15:17:08 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87pog1pqdn.fsf@lifelogs.com> References: <874lxeq6mz.fsf@lifelogs.com> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493061484 24706 195.159.176.226 (24 Apr 2017 19:18:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Apr 2017 19:18:04 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 24 21:17:57 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2jUi-0006Cc-Ti for ged-emacs-devel@m.gmane.org; Mon, 24 Apr 2017 21:17:57 +0200 Original-Received: from localhost ([::1]:45565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2jUo-0000te-Jj for ged-emacs-devel@m.gmane.org; Mon, 24 Apr 2017 15:18:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2jUB-0000tO-Uz for emacs-devel@gnu.org; Mon, 24 Apr 2017 15:17:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2jU7-0000v1-1E for emacs-devel@gnu.org; Mon, 24 Apr 2017 15:17:23 -0400 Original-Received: from [195.159.176.226] (port=42836 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2jU6-0000uM-Rh for emacs-devel@gnu.org; Mon, 24 Apr 2017 15:17:18 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d2jTx-0005BM-VN for emacs-devel@gnu.org; Mon, 24 Apr 2017 21:17:09 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 22 Original-X-Complaints-To: usenet@blaine.gmane.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:T23kS0dZdWk2kYfGnDeaAoHcvNQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214266 Archived-At: On Mon, 24 Apr 2017 23:24:13 +0530 Vibhav Pant wrote: >> Is it possible to also exclude fields with :json nil? I think that's >> very useful. VP> That would mean that all struct field will have to be explicitly declared VP> with a :json option to not be ignored. Instead, I've added a :json-ignore VP> option that makes json-encode-struct ignore the slot ignore it when it's VP> non-nil. Oh, right! Thank you for contributing this nice improvement. I look forward to using it. I also want to ask if the keywords could be less JSON-specific, since other serializers could be used. So you'd use keywords like :serialize-field, :serialize-ignore, :serialize-to-type instead of the ones you proposed. Finally, maybe we could also consider using the existing facility :print-function (the manual says that's currently unused). But I don't know the full implications of that, so maybe it's a bad suggestion. Ted