unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] json: Add support for encoding structs
Date: Mon, 24 Apr 2017 15:17:08 -0400	[thread overview]
Message-ID: <87pog1pqdn.fsf@lifelogs.com> (raw)
In-Reply-To: CA+T2Sh2Jbe7xOCbrFsrdX0meUSt0jc0vWQVfOJnEwDXMf4gc1g@mail.gmail.com

On Mon, 24 Apr 2017 23:24:13 +0530 Vibhav Pant <vibhavp@gmail.com> wrote: 

>> Is it possible to also exclude fields with :json nil? I think that's
>> very useful.
VP> That would mean that all struct field will have to be explicitly declared
VP> with a :json option to not be ignored. Instead, I've added a :json-ignore
VP> option that makes json-encode-struct ignore the slot ignore it when it's
VP> non-nil.

Oh, right! Thank you for contributing this nice improvement. I look
forward to using it.

I also want to ask if the keywords could be less JSON-specific, since
other serializers could be used. So you'd use keywords like
:serialize-field, :serialize-ignore, :serialize-to-type instead of the
ones you proposed.

Finally, maybe we could also consider using the existing facility
:print-function (the manual says that's currently unused). But I don't
know the full implications of that, so maybe it's a bad suggestion.

Ted




  reply	other threads:[~2017-04-24 19:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-23 10:16 [PATCH] json: Add support for encoding structs Vibhav Pant
2017-04-24 13:25 ` Ted Zlatanov
2017-04-24 17:54   ` Vibhav Pant
2017-04-24 19:17     ` Ted Zlatanov [this message]
2017-04-24 21:00       ` Ted Zlatanov
2017-04-24 21:43       ` Stefan Monnier
2017-04-25 14:26         ` Ted Zlatanov
2017-04-25 16:26           ` Vibhav Pant
2017-04-25 18:12             ` Ted Zlatanov
2017-04-26 12:13           ` Stefan Monnier
2017-04-27  6:50             ` Vibhav Pant
2017-04-27 12:31               ` Stefan Monnier
2017-04-25 12:27       ` Vibhav Pant
2017-04-24 22:52     ` Davis Herring
2017-04-25 12:40       ` Vibhav Pant
2017-04-24 13:45 ` Clément Pit-Claudel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pog1pqdn.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).