From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: libnettle/libhogweed WIP Date: Wed, 28 Jun 2017 15:44:05 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87podnnbi2.fsf@lifelogs.com> References: <83h91og80k.fsf@gnu.org> <87pogbuhoe.fsf@lifelogs.com> <834lxndmd9.fsf@gnu.org> <87efwrug6z.fsf@lifelogs.com> <87r30qu5av.fsf@lifelogs.com> <874lxmtxyy.fsf@lifelogs.com> <87r30prvwt.fsf@lifelogs.com> <8337d4csez.fsf@gnu.org> <87r30nq9el.fsf@lifelogs.com> <83inlyc1k2.fsf@gnu.org> <87inlyrfni.fsf@lifelogs.com> <837f2eb845.fsf@gnu.org> <87ziedpyy1.fsf@lifelogs.com> <83d1b75u8a.fsf@gnu.org> <87r2znntaq.fsf@lifelogs.com> <87o9u8q4a5.fsf@lifelogs.com> <83tw3xbklg.fsf@gnu.org> <87zictm415.fsf@lifelogs.com> <83podoqchd.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1498679082 21085 195.159.176.226 (28 Jun 2017 19:44:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Jun 2017 19:44:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 28 21:44:36 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQIt4-0004iZ-1d for ged-emacs-devel@m.gmane.org; Wed, 28 Jun 2017 21:44:30 +0200 Original-Received: from localhost ([::1]:35434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQIt6-00063z-8N for ged-emacs-devel@m.gmane.org; Wed, 28 Jun 2017 15:44:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQIsz-00063i-HA for emacs-devel@gnu.org; Wed, 28 Jun 2017 15:44:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQIsv-0002cK-Ae for emacs-devel@gnu.org; Wed, 28 Jun 2017 15:44:25 -0400 Original-Received: from [195.159.176.226] (port=54820 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dQIsv-0002bW-3t for emacs-devel@gnu.org; Wed, 28 Jun 2017 15:44:21 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dQIsm-00043w-Eb for emacs-devel@gnu.org; Wed, 28 Jun 2017 21:44:12 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 29 Original-X-Complaints-To: usenet@blaine.gmane.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:7Bh75q+gXTKoG+16Z8/DMC96Qew= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216039 Archived-At: On Wed, 28 Jun 2017 19:54:38 +0300 Eli Zaretskii wrote: >> From: Ted Zlatanov >> Date: Tue, 27 Jun 2017 18:58:30 -0400 >> >> There is only one major TODO I can't resolve: I asked for help before, >> and still can't make the autoconf code detect the GnuTLS functions >> individually. EZ> Doesn't something like AC_CHECK_FUNCS do the job? If not, why not? I tried to use that macro and many others, but it wouldn't include the right headers (gnutls/gnutls.h and gnutls/crypto.h). I eventually got it working with AC_COMPILE_IFELSE+AC_LANG_PROGRAM which I think will test definitions but not linkage. If anyone wants to provide a better solution, they could do it after merge or push it on top of my branch? EZ> You don't need a 'return' after calling 'error' (here and elsewhere), EZ> as the latter doesn't return. Those returns have now been removed. I'm not sure why I had warnings before, I must have misinterpreted something. Thanks for pointing it out, the code is that much shorter now. The "void *(*hash_func) (const char *, size_t, void *)" piece in fns.c gives a warning (incompatible assignment) if the first * is removed. I believe that's correct and we should keep it the way I had it before. Ted