From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: joaotavora@gmail.com (=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=) Newsgroups: gmane.emacs.devel Subject: Re: Refactoring flymake.el - jumped the gun Date: Mon, 21 Aug 2017 13:50:19 +0100 Message-ID: <87pobpw0dw.fsf@lolita> References: <87378q2r62.fsf@lolita> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1503319846 1451 195.159.176.226 (21 Aug 2017 12:50:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 21 Aug 2017 12:50:46 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: sdl.web@gmail.com To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 21 14:50:43 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djmA8-0008Fa-AH for ged-emacs-devel@m.gmane.org; Mon, 21 Aug 2017 14:50:36 +0200 Original-Received: from localhost ([::1]:42031 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djmAE-0001h3-JG for ged-emacs-devel@m.gmane.org; Mon, 21 Aug 2017 08:50:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djmA0-0001fR-CW for emacs-devel@gnu.org; Mon, 21 Aug 2017 08:50:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djm9x-0003PS-BZ for emacs-devel@gnu.org; Mon, 21 Aug 2017 08:50:28 -0400 Original-Received: from mail-wr0-x233.google.com ([2a00:1450:400c:c0c::233]:38284) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djm9x-0003MP-3o for emacs-devel@gnu.org; Mon, 21 Aug 2017 08:50:25 -0400 Original-Received: by mail-wr0-x233.google.com with SMTP id p8so34137376wrf.5 for ; Mon, 21 Aug 2017 05:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=75oaU+1RZpsuoxLRHYoqhiCPoRro1YcnVhow8XkkhuQ=; b=dPwEuciSybVXcpAZuuZhO1M28CM8EtEPbE0YSpSHRhAm655E2SRpxJvwuGViBDGI/4 plFEdkWs9HQM2jAr8SWNUPg2rtKutH+r3QL3YgrzGMhbFC5wGR2JJWYucg0CDofmB3cv qEflQMKVrZAYeik3gfKk5NcrLfJhGeYJwHDjU0jdop7lXz+kioR8bmvT3Nky8fLvwC0G EV9+EMgD9+PcW0P5dwQvPXrcwj8IhLkLsOFAmEEV4xsFhKkcXX402FNeNf/2jLCKOqOd l9+fid1NF3zDq0rS4dN178hQl88naIbcP8uSs9uqjngqN+iGI2qQmWj/qZcBT2lwvIYH x0AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=75oaU+1RZpsuoxLRHYoqhiCPoRro1YcnVhow8XkkhuQ=; b=mb3beFAG0ubHDxuqpRN9uU5sq5w+Ver7NUs84bkRk7scijom+ezGGXQWwRsBiPzTgz oJcOnQmO72ImWy6SR8fCXr0dLQIzUanpI73HkM6Jo+zgxrAH/RxaU2VSQxYW/fZUr/oo lkUBsgDZP3tbyA93nLrrhOooshQeG6AbSt9e6tZf5Fl4Oqm3xSMQfEJn/0d0Y+CCkRi7 YxNd9SK2ScznovH6S9jkUzTH18gvFr4nxsqoUT/qXllnU7zpk7pr6CiZJaUBVWp2I3qg vXIlWQXSxZCugcFMD1NNrKyC8brtaM6ppwvF/tynU4dCzSabzE6S7V83MItMqKGZJTOj VGTA== X-Gm-Message-State: AHYfb5iqyZLu5HuDmhF0yJ1Kl43wQO9ps+Vp2hRWOZtTmuke7GthPhzP VWkk0v/4qt3QLQ== X-Received: by 10.28.2.195 with SMTP id 186mr5385800wmc.83.1503319822734; Mon, 21 Aug 2017 05:50:22 -0700 (PDT) Original-Received: from lolita.yourcompany.com (48.6.108.93.rev.vodafone.pt. [93.108.6.48]) by smtp.gmail.com with ESMTPSA id e5sm2990132wma.31.2017.08.21.05.50.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Aug 2017 05:50:21 -0700 (PDT) In-Reply-To: <87378q2r62.fsf@lolita> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora?= =?utf-8?Q?=22's?= message of "Thu, 17 Aug 2017 15:40:53 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217652 Archived-At: joaotavora@gmail.com (Jo=C3=A3o T=C3=A1vora) writes: > So here's what I have so far. In a newly pushed git branch: > > scratch/flymake-refactor > > there are just two commits right now: > > eb34f7f5a2 Split flymake.el into flymake-proc.el and flymake-ui.el > 13993c46a2 Add flymake-backends defcustom Unfortunately, I seemed to have jumped the gun and inadvertently pushed these commits into master instead of keeping them in the scratch/flymake-refactor branch until I got some reviews, which naturally was my intention. So sorry about that. As I explained they are a very simple innocuous and backward compatible refactoring, which is probably why they didn't break any tests (and nobody apparently noticed). However, since they were pushed in error, I can revert them if someone feels that's necessary. Best, Jo=C3=A3o