From: joaotavora@gmail.com (João Távora)
To: emacs-devel@gnu.org
Cc: sdl.web@gmail.com
Subject: Re: Refactoring flymake.el - jumped the gun
Date: Mon, 21 Aug 2017 13:50:19 +0100 [thread overview]
Message-ID: <87pobpw0dw.fsf@lolita> (raw)
In-Reply-To: <87378q2r62.fsf@lolita> ("João Távora"'s message of "Thu, 17 Aug 2017 15:40:53 +0100")
joaotavora@gmail.com (João Távora) writes:
> So here's what I have so far. In a newly pushed git branch:
>
> scratch/flymake-refactor
>
> there are just two commits right now:
>
> eb34f7f5a2 Split flymake.el into flymake-proc.el and flymake-ui.el
> 13993c46a2 Add flymake-backends defcustom
Unfortunately, I seemed to have jumped the gun and inadvertently pushed
these commits into master instead of keeping them in the
scratch/flymake-refactor branch until I got some reviews, which
naturally was my intention. So sorry about that.
As I explained they are a very simple innocuous and backward compatible
refactoring, which is probably why they didn't break any tests (and
nobody apparently noticed).
However, since they were pushed in error, I can revert them if someone
feels that's necessary.
Best,
João
next prev parent reply other threads:[~2017-08-21 12:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 14:40 Refactoring flymake.el João Távora
2017-08-17 16:57 ` John Wiegley
2017-08-17 18:08 ` Sam Steingold
2017-08-17 22:32 ` Stefan Monnier
2017-08-18 14:51 ` Sam Steingold
2017-08-18 15:11 ` Dmitry Gutov
2017-08-18 16:13 ` Sam Steingold
2017-08-18 16:25 ` Dmitry Gutov
2017-08-18 17:59 ` Sam Steingold
2017-08-18 18:52 ` Noam Postavsky
2017-08-18 19:38 ` Sam Steingold
2017-08-18 16:26 ` Clément Pit-Claudel
2017-08-18 20:32 ` Stefan Monnier
2017-08-18 13:04 ` Dmitry Gutov
2017-08-18 19:20 ` João Távora
2017-08-19 1:59 ` Leo Liu
2017-08-21 12:50 ` João Távora [this message]
2017-08-23 3:30 ` Refactoring flymake.el - jumped the gun Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pobpw0dw.fsf@lolita \
--to=joaotavora@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).